Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show "Changing Shield settings in this way..." only once in Private Window #12156

Closed
360fun opened this issue Oct 15, 2020 · 3 comments
Closed

Show "Changing Shield settings in this way..." only once in Private Window #12156

360fun opened this issue Oct 15, 2020 · 3 comments
Labels
closed/duplicate Issue has already been reported feature/shields/panel Front-end design and functionality of the Shields panel. OS/Desktop priority/P4 Planned work. We expect to get to it "soon".

Comments

@360fun
Copy link

360fun commented Oct 15, 2020

I find really annoying to see "Changing Shield settings in this way may affect web compatibility on this site." every time I try to disable the Ads Shield on a new Private Window.

image

I would like Brave to show it just once and, after pressing the OK button, never show it again (this is the behaviour I expected).
@rebron rebron added feature/shields/panel Front-end design and functionality of the Shields panel. priority/P4 Planned work. We expect to get to it "soon". labels Jan 22, 2021
@rebron
Copy link
Collaborator

rebron commented Jan 22, 2021

@karenkliu This shields notification should only show once. Agree?

@karenkliu
Copy link

@rebron Correct. Let's not show this message for Private & Private Window with Tor.

@karenkliu
Copy link

Closing this as a dupe; it'll be fixed in #16654

@karenkliu karenkliu added the closed/duplicate Issue has already been reported label Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/duplicate Issue has already been reported feature/shields/panel Front-end design and functionality of the Shields panel. OS/Desktop priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@360fun @karenkliu @rebron