Calculate Order expires_at Using valid_for_iso #1865
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is aiming at addressing #1864.
The validity period in ISO format is not part of the order data. It's available on the order's item. (While the code technically allows multiple items per order, at present there is always one item. Consulted with real data).
The fix works as follows:
expires_at
(which is when an order goes topaid
), fetch it's items.valid_for_iso
.valid_for
for calculatingexpires_at
.Type of Change
Tested Environments
Before Submitting This PR
Manual Test Plan