Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure trained_model is a Path before calling .suffix #471

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Nov 14, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Latest brainmapper fails because of a missing attribute when you call it with --trained_model.

What does this PR do?

Converts trained_model to Path before calling .suffix

References

Closes #470

How has this PR been tested?

Local manual tests with brainmapper by both @JRegg66 (thank you) and myself.
Local running of cellfinder tests.

Is this a breaking change?

No

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@alessandrofelder alessandrofelder marked this pull request as ready for review November 14, 2024 11:05
@alessandrofelder alessandrofelder requested a review from a team November 14, 2024 11:06
Copy link
Member

@niksirbi niksirbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@niksirbi niksirbi merged commit efc0f67 into main Nov 14, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Path to trained model from brainmapper is a str, and doesn't have .suffix attribute
2 participants