Fix pathing problems #260
Merged
Fix pathing problems #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the tests are still failing, but it looks like a genuine test fail now? Rather than a path problem. Feel free to push to this branch or merge in and fix on yours. |
alessandrofelder
merged commit 9bde054
into
fix-pandas-deprecation
4 of 7 checks passed
|
I'll merge and fix on my branch (have already fixed one of the problems locally) - thanks! |
|
No problem - fingers crossed I haven't undone that local fix 😅 |
willGraham01
added a commit
that referenced
this pull request
Nov 15, 2023
* add a failing test for get_region_totals reproduces #254 fails as expected with pandas 2.1.3 passes with pandas 1.5.3 a dummy volumes.csv created by cutting down version from registration_output data * distribute test points across region/hemisphere, save regression data regression data from pandas 1.5.3 * basic local fix * use safe_concat util instead * tweak test avoid using hard-coded paths and writing tmp data to codebase * Fix pathing problems (#260) * adapt test_subdirectories to extra data subdir --------- Co-authored-by: Will Graham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alessandrofelder Noticed your test data wasn't being found because our
MANIFESTis told to ignore thetestsdirectory when packaging.Changed the
toxcommand and paths in the to-be regression tests to point to the repository clone, which should then resolve the paths correctly using the repo clone.