Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move hover coords to pixel space #168

Merged
merged 2 commits into from
Dec 10, 2024
Merged

move hover coords to pixel space #168

merged 2 commits into from
Dec 10, 2024

Conversation

alessandrofelder
Copy link
Member

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

What does this PR do?
Tooltip hovering should be in pixel space since 0.0.5 but it was left in micron space.
This PR moves the hovering tooltip to pixel space.

References

Closes #167

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@alessandrofelder alessandrofelder self-assigned this Dec 10, 2024
@alessandrofelder alessandrofelder requested a review from a team December 10, 2024 13:54
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.75%. Comparing base (9a24190) to head (1cd45eb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #168   +/-   ##
=======================================
  Coverage   82.75%   82.75%           
=======================================
  Files          12       12           
  Lines         551      551           
=======================================
  Hits          456      456           
  Misses         95       95           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamltyson adamltyson merged commit efac552 into main Dec 10, 2024
13 checks passed
@adamltyson adamltyson deleted the hover-in-pixel-space branch December 10, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Hover functionality is still in micron space
2 participants