Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce test data size and relax test timouts #162

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Oct 18, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

Tests were timing out weirdly, and spuriously on CI only, presumably because of connectivity issues.

What does this PR do?
Simplifies the tests by removing the fish atlas (which was there because we wanted tests for additional-reference related functionality), and implementing a manual mocking an additional reference for the example mouse atlas instead.

References

Closes #158

How has this PR been tested?

Makes CI reliably pass again from what I can see.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.75%. Comparing base (059d669) to head (a0e50b9).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (059d669) and HEAD (a0e50b9). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (059d669) HEAD (a0e50b9)
8 6
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #162       +/-   ##
===========================================
- Coverage   98.06%   82.75%   -15.31%     
===========================================
  Files          11       12        +1     
  Lines         465      551       +86     
===========================================
  Hits          456      456               
- Misses          9       95       +86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessandrofelder alessandrofelder changed the title Update test_atlas_manager_view.py Accelerate tests and relax their timouts Oct 18, 2024
@alessandrofelder alessandrofelder force-pushed the try-longer-timeout-for-atlas-update-test branch from 5feacad to 34fc79c Compare October 18, 2024 17:01
@alessandrofelder alessandrofelder changed the title Accelerate tests and relax their timouts reduce test data size and relax test timouts Oct 18, 2024
@alessandrofelder
Copy link
Member Author

Now that everything is cached again, tests finally pass 🎉

@alessandrofelder alessandrofelder marked this pull request as ready for review October 30, 2024 13:38
@alessandrofelder alessandrofelder requested a review from a team October 30, 2024 13:38
@adamltyson adamltyson merged commit c33283a into main Oct 30, 2024
12 of 13 checks passed
@adamltyson adamltyson deleted the try-longer-timeout-for-atlas-update-test branch October 30, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Tests fail in CI - investigation needed
2 participants