Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganise scripts in examples folders #43

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

niksirbi
Copy link
Member

I tried to put some order to the examples folder, this is what I came up with:

.
├── blackcap
│   ├── 1_source_images.py
│   ├── 2_prep_lowres.py
│   ├── 3_prep_highres.py
│   ├── 4_build_template.sh
│   └── 5_post_build.py
├── slurm
│   ├── batch_across_average_types.sh
│   ├── batch_across_templates.sh
│   ├── build_template.sh
│   └── post_build.sh
└── tadpole
    └── 1_downsample_source_images.py

The logic being that there is one "preprocessing" folder per species, and the scripts there-in are numbered in order of execution. SLURM scripts are separate, because in theory they can be very easily adapted cross-species.

This was mostly done to clear up my "mental workspace" in preparation for making new templates. Let me know if it makes sense.

This PR does nothing else than renaming/moving files, no code was changed.

@niksirbi
Copy link
Member Author

Should be rebase to main after #44 is merged, to fix the linkcheck error.

@niksirbi niksirbi marked this pull request as ready for review October 17, 2024 11:48
Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot, at least for now. We should make sure to avoid code duplication across species-specific scripts, to the extent possible - but this is a general and unrelated point.

@alessandrofelder alessandrofelder merged commit 03df9e9 into main Oct 17, 2024
22 of 23 checks passed
@alessandrofelder alessandrofelder deleted the put-blackcaps-scripts-in-subfolders branch October 17, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants