Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename to brainglobe-space #42

Merged
merged 7 commits into from
Jan 24, 2024
Merged

Rename to brainglobe-space #42

merged 7 commits into from
Jan 24, 2024

Conversation

willGraham01
Copy link
Collaborator

@willGraham01 willGraham01 commented Jan 24, 2024 •
edited
Loading

See #37

Depends on #41 and releasing the "final" bg-space version - don't merge till ready!

@willGraham01 willGraham01 changed the base branch from main to retire-old-name January 24, 2024 10:37
@willGraham01 willGraham01 mentioned this pull request Jan 24, 2024
Closed
16 tasks
@willGraham01 willGraham01 marked this pull request as ready for review January 24, 2024 11:02
@willGraham01 willGraham01 requested a review from a team January 24, 2024 11:03
alessandrofelder
alessandrofelder approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, can be merged once #41 is released

@willGraham01
Copy link
Collaborator Author

willGraham01 commented Jan 24, 2024 •
edited
Loading

Looks good to me, can be merged once #41 is released

I think (in the interest of development speed) we can merge #41, tag bg-space v0.7.0 as the final release, and then merge this in and perform the rename. We can then do all the renaming etc and release brainglobe-space. When we find someone with bg-space access on PyPI, they can checkout v0.7.0 and upload it to PyPI? (Give me a shout if you're happy with this)

This means we can move onto updating all the dependent packages and shipping a meta-package v1.1.0

@alessandrofelder
Copy link
Member

Happy with this!

Base automatically changed from retire-old-name to main January 24, 2024 11:54
@willGraham01 willGraham01 merged commit 671834a into main Jan 24, 2024
8 checks passed
@willGraham01 willGraham01 deleted the rename-package branch January 24, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessandrofelder alessandrofelder alessandrofelder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willGraham01 @alessandrofelder