Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in dependency #62

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Fix typo in dependency #62

merged 1 commit into from
Jan 12, 2024

Conversation

adamltyson
Copy link
Member

Doesn't seem to cause any problems though 🤷

@adamltyson adamltyson requested a review from a team January 11, 2024 17:31
willGraham01
willGraham01 approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@willGraham01 willGraham01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think (?) that pyproject is smart enough to auto-translate _ to - when parsing dependencies. Don't quote me on that though. Could also be because bg-atlasapi depends on bg-space so it's being implicitly fetched.

@adamltyson adamltyson merged commit 3128b6c into main Jan 12, 2024
22 checks passed
@adamltyson adamltyson deleted the pyproject-typo branch January 12, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willGraham01 willGraham01 willGraham01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamltyson @willGraham01