Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save points layer to xml even if there isn't any metadata #56

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Save points layer to xml even if there isn't any metadata #56

merged 1 commit into from
Dec 18, 2023

Conversation

adamltyson
Copy link
Member

Closes #20

@adamltyson
Copy link
Member Author

Tests are failing because of brainglobe/brainglobe-utils#18

@adamltyson adamltyson mentioned this pull request Dec 18, 2023
Merged
alessandrofelder
alessandrofelder approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have triggered a re-run of the tests and will merge if they pass. Code changes look good to me.

@adamltyson
Copy link
Member Author

Have triggered a re-run of the tests and will merge if they pass. Code changes look good to me.

I'll run it again, brainglobe-utils hadn't been re-released yet.

@alessandrofelder alessandrofelder merged commit 3e910f4 into main Dec 18, 2023
10 of 12 checks passed
@alessandrofelder alessandrofelder deleted the xml-save branch December 18, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessandrofelder alessandrofelder alessandrofelder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error in saving selected layers as brainglobe-napari-io points (.xml)
2 participants
@adamltyson @alessandrofelder