Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make list atlas function more robust #417

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Make list atlas function more robust #417

merged 2 commits into from
Oct 29, 2024

Conversation

adamltyson
Copy link
Member

The existing function returned garbage if there was a "_v" anywhere in the atlas name (e.g. "prairie_vole"), and also didn't produce anything informative if the atlas couldn't be found. This PR makes this function more robust and adds error handling.

@adamltyson adamltyson requested a review from a team October 29, 2024 11:55
Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion to add a test, but otherwise happy.

brainglobe_atlasapi/list_atlases.py Show resolved Hide resolved
@alessandrofelder alessandrofelder merged commit 04043bc into main Oct 29, 2024
13 checks passed
@alessandrofelder alessandrofelder deleted the list-atlases branch October 29, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants