New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DPS shutdown mode an enumerable value set #11

Open

b-rowan wants to merge 2 commits into braiins:main from b-rowan:main

b-rowan commented Dec 11, 2023

This PR moves DPS shutdown mode into an enum (oneof), since shutdown duration should not be passed if DPS shutdown is disabled.

Changes:

Create DPSShutdownEnabled message and DPSShutdownDisabled message
Move shutdown duration to DPSShutdownEnabled
Add shutdown_mode to DPSConfiguration
Add shutdown_mode to SetDPSRequest

b-rowan added 2 commits

December 11, 2023 10:39


          Make DPS shutdown mode an enumerable value set instead of a boolean

1445d7e


          Fix value numbering, and add shutdown_mode to SetDPSRequest

dbea28c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet