chore: Update Node #799
Merged
chore: Update Node #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsgoulart
force-pushed
the
update-node
branch
from
a5e02be to
ced45d0
Compare
pinussilvestrus
force-pushed
the
update-node
branch
from
3c0a847 to
64174cf
Compare
pinussilvestrus
force-pushed
the
update-node
branch
from
64174cf to
43a8bbc
Compare
|
@Skaiir @vsgoulart I was able to fix the three test cases by using |
|
pinging @bpmn-io/modeling-dev that we're targetting Node@18 now for our CI, with the reasons mentioned above (End of Life). |
|
Any reason you don't switch to Node@20 right away? I guess that is what we'd attempt to do, to safe some effort in 1 year. |
|
Created a tracking issue on our end, thanks for the heads-up @pinussilvestrus 🏅 |
No real reason, we will go to 20 directly in case we see no blockers 👍 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node v16 reached end of life