Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/docker update #948

Merged
merged 9 commits into from
Oct 27, 2024
Merged

Feature/docker update #948

merged 9 commits into from
Oct 27, 2024

Conversation

grasdk
Copy link
Contributor

@grasdk grasdk commented Oct 25, 2024

Resolves issue 777

Also adds linting checks to dockerfiles and resolves linting errors. Linting errors about versioning packages are ignored (DL3008 and DL3018)

@bpatrik
Copy link
Owner

bpatrik commented Oct 27, 2024

Thanks. I did not test how removing the Volume tags would change the behavior, but I will just take your word that it will just keep working.

@bpatrik bpatrik merged commit 42400fa into bpatrik:master Oct 27, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop using VOLUME in the Dockerfile
2 participants