Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add phpbench #1204

Merged
merged 10 commits into from
Nov 24, 2023
Merged

build: Add phpbench #1204

merged 10 commits into from
Nov 24, 2023

Conversation

theofidry
Copy link
Member

@theofidry theofidry commented Nov 24, 2023

No description provided.

@theofidry theofidry marked this pull request as ready for review November 24, 2023 16:44
@theofidry theofidry merged commit 4e6c8c4 into box-project:main Nov 24, 2023
58 of 59 checks passed
@theofidry theofidry deleted the fix/phpbench branch November 24, 2023 16:58
theofidry added a commit that referenced this pull request Nov 24, 2023
Follow up of #1204 which required to have a workflow landing in `main`.

This PR:

- Moves the `res` directory included for the benchmarked code to avoid potential FS issues.
- Run another job: the PHPBench for the PR, without comparing with `main`, to have some feedback in case the PHPBench in `main` fails.
- Do not fail if the performance target is not met: this is work for the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant