refactor: Move finding the PHP or Box bin into a dedicated class

src/ExecutableFinder.php

@@ -0,0 +1,52 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * This file is part of the box project.
+ *
+ * (c) Kevin Herrera <[email protected]>
+ *     Théo Fidry <[email protected]>
+ *
+ * This source file is subject to the MIT license that is bundled
+ * with this source code in the file LICENSE.
+ */
+
+namespace KevinGH\Box;
+
+use RuntimeException;
+use Symfony\Component\Process\PhpExecutableFinder as SymfonyPhpExecutableFinder;
+
+final class ExecutableFinder
+{
+    private static string $boxExecutable;
+    private static string $phpExecutable;
+
+    public static function findBoxExecutable(): string
+    {
+        if (isset(self::$boxExecutable)) {
+            return self::$boxExecutable;
+        }
+
+        self::$boxExecutable = getenv(Constants::BIN) ?: $_SERVER['SCRIPT_NAME'];
+
+        return self::$boxExecutable;
+    }
+
+    public static function findPhpExecutable(): string
+    {
+        if (isset(self::$phpExecutable)) {
+            return self::$phpExecutable;
+        }
+
+        $phpExecutable = (new SymfonyPhpExecutableFinder())->find();
+
+        if (false === $phpExecutable) {
+            throw new RuntimeException('Could not find a PHP executable.');
+        }
+
+        self::$phpExecutable = $phpExecutable;
+
+        return self::$phpExecutable;
+    }
+}

src/Phar/PharInfo.php

@@ -45,19 +45,16 @@
 
 use Fidry\FileSystem\FS;
 use KevinGH\Box\Console\Command\Extract;
-use KevinGH\Box\Constants;
+use KevinGH\Box\ExecutableFinder;
 use OutOfBoundsException;
 use Phar;
-use RuntimeException;
 use Symfony\Component\Filesystem\Path;
 use Symfony\Component\Finder\Finder;
 use Symfony\Component\Finder\SplFileInfo;
 use Symfony\Component\Process\Exception\ProcessFailedException;
-use Symfony\Component\Process\PhpExecutableFinder;
 use Symfony\Component\Process\Process;
 use function bin2hex;
 use function file_exists;
-use function getenv;
 use function is_readable;
 use function iter\mapKeys;
 use function iter\toArrayWithKeys;
@@ -287,9 +284,9 @@
 
     private static function dumpPhar(string $file, string $tmp): void
     {
         $extractPharProcess = new Process([
-            self::getPhpExecutable(),
-            self::getBoxBin(),
+            ExecutableFinder::findPhpExecutable(),
+            ExecutableFinder::findBoxExecutable(),
             'extract',
             $file,
             $tmp,
@@ -329,28 +326,6 @@
         return [$meta, $dumpedFiles];
     }
 
-    private static function getPhpExecutable(): string
-    {
-        if (isset(self::$phpExecutable)) {
-            return self::$phpExecutable;
-        }
-
-        $phpExecutable = (new PhpExecutableFinder())->find();
-
-        if (false === $phpExecutable) {
-            throw new RuntimeException('Could not find a PHP executable.');
-        }
-
-        self::$phpExecutable = $phpExecutable;
-
-        return self::$phpExecutable;
-    }
-
-    private static function getBoxBin(): string
-    {
-        return getenv(Constants::BIN) ?: $_SERVER['SCRIPT_NAME'];
-    }
-
     /**
      * @param array<string, array{'compression': CompressionAlgorithm, compressedSize: int}> $filesMeta
      */