Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Get the raw output for the Composer version #1063

Merged
merged 2 commits into from
Oct 13, 2023
Merged

fix: Get the raw output for the Composer version #1063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e78fca
fix: Get the raw output for the Composer version
theofidry Oct 11, 2023
05c2826
fix tests
theofidry Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Composer/ComposerOrchestrator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public static function getVersion(
$logger = new CompilerLogger($io ?? IO::createNull());

$composerExecutable = $composerBin ?? self::retrieveComposerExecutable();
$getVersionProcess = new Process([$composerExecutable, '--version']);
$getVersionProcess = new Process([$composerExecutable, '--version', '--no-ansi']);

$logger->log(
CompilerLogger::CHEVRON_PREFIX,
Expand Down
4 changes: 2 additions & 2 deletions tests/Console/Command/CompileTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,7 +858,7 @@ public function test_it_can_build_a_phar_file_in_verbose_mode(): void

? Removing the existing PHAR "/path/to/tmp/test.phar"
? Checking Composer compatibility
> '/usr/local/bin/composer' '--version'
> '/usr/local/bin/composer' '--version' '--no-ansi'
> 2.5.0 (Box requires ^2.2.0)
> Supported version detected
? Registering compactors
Expand Down Expand Up @@ -986,7 +986,7 @@ public function test_it_can_build_a_phar_file_in_very_verbose_mode(): void

? Removing the existing PHAR "/path/to/tmp/test.phar"
? Checking Composer compatibility
> '/usr/local/bin/composer' '--version'
> '/usr/local/bin/composer' '--version' '--no-ansi'
> 2.5.0 (Box requires ^2.2.0)
> Supported version detected
? Registering compactors
Expand Down
Loading