Skip to content

Commit

Permalink
test: Fix PharFactoryTest (#1026)
Browse files Browse the repository at this point in the history
Revert #1024: the actual issue is about whether the phar.readonly is on or off rather than the PHP version.
  • Loading branch information
theofidry authored Oct 6, 2023
1 parent d524001 commit fc2c209
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion tests/Phar/PharFactoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

use KevinGH\Box\Pharaoh\InvalidPhar;
use KevinGH\Box\Platform;
use KevinGH\Box\Test\RequiresPharReadonlyOff;
use Phar;
use PharData;
use PHPUnit\Framework\TestCase;
Expand All @@ -27,14 +28,22 @@
* @covers \KevinGH\Box\Pharaoh\InvalidPhar
*
* @runTestsInSeparateProcesses
* @requires PHP 8.2.0
*
* @internal
*/
final class PharFactoryTest extends TestCase
{
private const FIXTURES_DIR = __DIR__.'/../../fixtures/phar';

use RequiresPharReadonlyOff;

protected function setUp(): void
{
$this->markAsSkippedIfPharReadonlyIsOn();

parent::setUp();
}

/**
* @dataProvider validPharProvider
*/
Expand Down

0 comments on commit fc2c209

Please sign in to comment.