fix: Fix the ComposerOrchestrator in quiet verbosity (#1087)

The verbosity (and ANSI/no-ANSI) of the IO should not inpact those processes.
box-project · Oct 17, 2023 · c4a7823 · c4a7823
1 parent 1105b7d
commit c4a7823
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 14 deletions.
diff --git a/src/Composer/ComposerOrchestrator.php b/src/Composer/ComposerOrchestrator.php
@@ -131,7 +131,7 @@ public function dumpAutoload(
 
     public function getVendorDir(): string
     {
-        $vendorDirProcess = $this->processFactory->getAutoloadFileProcess();
+        $vendorDirProcess = $this->processFactory->getVendorDirProcess();
 
         $this->logger->info($vendorDirProcess->getCommandLine());
 

diff --git a/src/Composer/ComposerProcessFactory.php b/src/Composer/ComposerProcessFactory.php
@@ -49,12 +49,17 @@ public function __construct(
 
     public function getVersionProcess(): Process
     {
-        // Never use ANSI support here as we want to parse the raw output.
-        return $this->createProcess([
-            $this->composerExecutable,
-            '--version',
-            '--no-ansi',
-        ]);
+        return $this->createProcess(
+            [
+                $this->composerExecutable,
+                '--version',
+                // Never use ANSI support here as we want to parse the raw output.
+                '--no-ansi',
+            ],
+            // Ensure that even if this command gets executed within the app with --quiet it still
+            // works.
+            ['SHELL_VERBOSITY' => 0],
+        );
     }
 
     public function getDumpAutoloaderProcess(bool $noDev): Process
@@ -76,14 +81,20 @@ public function getDumpAutoloaderProcess(bool $noDev): Process
         return $this->createProcess($composerCommand);
     }
 
-    public function getAutoloadFileProcess(): Process
+    public function getVendorDirProcess(): Process
     {
-        return $this->createProcess([
-            $this->composerExecutable,
-            'config',
-            'vendor-dir',
-            '--no-ansi',
-        ]);
+        return $this->createProcess(
+            [
+                $this->composerExecutable,
+                'config',
+                'vendor-dir',
+                // Never use ANSI support here as we want to parse the raw output.
+                '--no-ansi',
+            ],
+            // Ensure that even if this command gets executed within the app with --quiet it still
+            // works.
+            ['SHELL_VERBOSITY' => 0],
+        );
     }
 
     private function createProcess(array $command, array $environmentVariables = []): Process