test(requirement-checker): Fix the requirement checker e2e tests (#1178)

box-project · Nov 19, 2023 · 186f264 · 186f264
1 parent fed7da1
commit 186f264
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 18 deletions.
diff --git a/requirement-checker/fixtures/fail-complete/expected-boxmin-stderr.dist b/requirement-checker/fixtures/fail-complete/expected-boxmin-stderr.dist
@@ -6,11 +6,11 @@ Box Requirements Checker
 > PHP is not using any php.ini file.
 
 > Checking Box requirements:
-  ✘ The application requires a version matching "^10".
-  ✔ The application requires the extension "phar".
+  ✘ This application requires a PHP version matching "^10".
+  ✔ This application requires the extension "phar".
   ✔ The package "package-with-extensions" requires the extension "json".
   ✘ The package "package-with-extensions" requires the extension "ldap".
-  ✘ The package "package-with-extensions" requires the extension "random".
+  ✔ The package "package-with-extensions" requires the extension "random".
 
 
  [ERROR] Your system is not ready to run the application.                       
@@ -19,11 +19,8 @@ Box Requirements Checker
 Fix the following mandatory requirements:
 =========================================
 
- * The application requires a version matching "^10".
+ * This application requires a PHP version matching "^10".
  * The package "package-with-extensions" requires the extension "ldap". You
    either need to enable it or request the application to be shipped with a
    polyfill for this extension.
- * The package "package-with-extensions" requires the extension "random". You
-   either need to enable it or request the application to be shipped with a
-   polyfill for this extension.
 
diff --git a/requirement-checker/fixtures/fail-complete/expected-composermin-stderr.dist b/requirement-checker/fixtures/fail-complete/expected-composermin-stderr.dist
@@ -6,8 +6,8 @@ Box Requirements Checker
 > PHP is not using any php.ini file.
 
 > Checking Box requirements:
-  ✘ The application requires a version matching "^10".
-  ✔ The application requires the extension "phar".
+  ✘ This application requires a PHP version matching "^10".
+  ✔ This application requires the extension "phar".
   ✔ The package "package-with-extensions" requires the extension "json".
   ✘ The package "package-with-extensions" requires the extension "ldap".
   ✘ The package "package-with-extensions" requires the extension "random".
@@ -19,7 +19,7 @@ Box Requirements Checker
 Fix the following mandatory requirements:
 =========================================
 
- * The application requires a version matching "^10".
+ * This application requires a PHP version matching "^10".
  * The package "package-with-extensions" requires the extension "ldap". You
    either need to enable it or request the application to be shipped with a
    polyfill for this extension.

diff --git a/requirement-checker/fixtures/fail-conflict/expected-boxmin-stderr.dist b/requirement-checker/fixtures/fail-conflict/expected-boxmin-stderr.dist
@@ -6,8 +6,8 @@ Box Requirements Checker
 > PHP is not using any php.ini file.
 
 > Checking Box requirements:
-  ✔ The application requires the extension "phar".
-  ✘ The application conflicts with the extension "pdo".
+  ✔ This application requires the extension "phar".
+  ✘ This application conflicts with the extension "pdo".
 
 
  [ERROR] Your system is not ready to run the application.                       
@@ -16,6 +16,6 @@ Box Requirements Checker
 Fix the following mandatory requirements:
 =========================================
 
- * The application conflicts with the extension "pdo". You need to disable it in
-   order to run this application.
+ * This application conflicts with the extension "pdo". You need to disable it
+   in order to run this application.
 
diff --git a/requirement-checker/fixtures/pass-complete/expected-boxmin-stderr.dist b/requirement-checker/fixtures/pass-complete/expected-boxmin-stderr.dist
@@ -6,8 +6,8 @@ Box Requirements Checker
 > PHP is not using any php.ini file.
 
 > Checking Box requirements:
-  ✔ The application requires a version matching ">=5.3".
-  ✔ The application requires the extension "phar".
+  ✔ This application requires a PHP version matching ">=5.3".
+  ✔ This application requires the extension "phar".
 
 
  [OK] Your system is ready to run the application.                              

diff --git a/requirement-checker/fixtures/pass-complete/expected-composermin-stderr.dist b/requirement-checker/fixtures/pass-complete/expected-composermin-stderr.dist
@@ -6,8 +6,8 @@ Box Requirements Checker
 > PHP is not using any php.ini file.
 
 > Checking Box requirements:
-  ✔ The application requires a version matching ">=5.3".
-  ✔ The application requires the extension "phar".
+  ✔ This application requires a PHP version matching ">=5.3".
+  ✔ This application requires the extension "phar".
 
 
  [OK] Your system is ready to run the application.