Skip to content

Commit

Permalink
eslint: Update spellchecker and fix issues
Browse files Browse the repository at this point in the history
The performance issues with the spellcheck plugins were resolved
aotaduy/eslint-plugin-spellcheck#44

This commit updates the dependency to the latest version and fixes
several spelling issues.
  • Loading branch information
borisyankov committed Sep 13, 2018
1 parent bba1ada commit 564545c
Show file tree
Hide file tree
Showing 7 changed files with 24 additions and 17 deletions.
5 changes: 4 additions & 1 deletion .eslintrc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -124,4 +124,7 @@ rules:
const, wildcard, reactotron, camelcase, hydrator, perf, stacktrace, Dir, fs,
avoider, octicons, centerer, ldap, gravatar, identicon, blueimp, filename, wildcards,
jpeg, jpg, tif, mov, notif, diag, bmp, viewport, scalable, polyfill, rect, touchstart,
touchend, touchmove, remoteuser, sso, submessages, nbsp, args, px, na]
touchend, touchmove, remoteuser, sso, submessages, nbsp, args, px, na,
readthedocs, zerver, linter, lifecycle, mozilla, subtree, zlib, lt, lector, overlayed,
rehydration, howto, hotspots, pressable, uncomment,
rt2zz, bd20a756f9, issuecomment]
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
"eslint-plugin-prettier": "^2.6.0",
"eslint-plugin-react": "^7.8.2",
"eslint-plugin-react-native": "^3.2.1",
"eslint-plugin-spellcheck": "0.0.6",
"eslint-plugin-spellcheck": "^0.0.11",
"flow-bin": "^0.67.0",
"flow-coverage-report": "^0.6.0",
"flow-typed": "^2.4.0",
Expand Down
2 changes: 1 addition & 1 deletion src/common/UnreadCount.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ type Props = {
* @prop [count] - Numerical value for the unread count.
* @prop [isMuted] - Flag indicating the entity to which the
* unread count value is related is muted. Styled differently.
* @prop [inverse] - Indicate if styling should be inversed (dark on light).
* @prop [inverse] - Indicate if styling should be inverted (dark on light).
* @prop [limited] - If set values over 100 will display as `99+`.
*/
export default class UnreadCount extends PureComponent<Props> {
Expand Down
2 changes: 1 addition & 1 deletion src/utils/encoding.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export const hexToBase64 = (hex: string) => base64.encode(hexToAscii(hex));
* Encode a string as the base64 representation of its UTF-8 bytes.
*
* This lets us pass an arbitrary string through a channel (like the
* `postMessage` on RN's webviews on Android) that tries to do something
* `postMessage` on RN's WebViews on Android) that tries to do something
* like percent-decode it.
*/
export const base64Utf8Encode = (text: string): string =>
Expand Down
2 changes: 1 addition & 1 deletion src/utils/presence.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const OFFLINE_THRESHOLD_SECS = 140;
* the subsystem doc:
* https://zulip.readthedocs.io/en/latest/subsystems/presence.html
*
* This logic should match `status_from_timestamp` in the webapp's
* This logic should match `status_from_timestamp` in the web app's
* `static/js/presence.js`.
*/
export const getAggregatedPresence = (presence: Presence): PresenceAggregated =>
Expand Down
2 changes: 1 addition & 1 deletion src/webview/js/js.js
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ const handleLongPress = e => {
// It would be good to clean it up to be clearer.
//
// At the same time, the logic is believed not to cover all the cases it
// should; for example, multitouch events. Better would be to either find
// should; for example, multi-touch events. Better would be to either find
// a library we can use which strives to handle all that complexity, or
// get long-press events from the platform.
if (!lastTouchEventTimestamp || Date.now() - lastTouchEventTimestamp < 500) {
Expand Down
26 changes: 15 additions & 11 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2443,13 +2443,13 @@ eslint-plugin-react@^7.8.2:
jsx-ast-utils "^2.0.1"
prop-types "^15.6.0"

[email protected].6:
version "0.0.6"
resolved "https://registry.yarnpkg.com/eslint-plugin-spellcheck/-/eslint-plugin-spellcheck-0.0.6.tgz#bd5b5c93864dee3baa2db4f603983c8e29d39634"
eslint-plugin-spellcheck@^0.0.11:
version "0.0.11"
resolved "https://registry.yarnpkg.com/eslint-plugin-spellcheck/-/eslint-plugin-spellcheck-0.0.11.tgz#f3fcff70a0446e1f04eacd5ebaa8cab23e691b4a"
dependencies:
globals "^6.4.1"
hunspell-spellchecker "^1.0.0"
lodash "^3.3.1"
globals "^11.3.0"
hunspell-spellchecker "^1.0.2"
lodash "^4.14.2"

eslint-restricted-globals@^0.1.1:
version "0.1.1"
Expand Down Expand Up @@ -3091,9 +3091,9 @@ globals@^11.1.0:
version "11.1.0"
resolved "https://registry.yarnpkg.com/globals/-/globals-11.1.0.tgz#632644457f5f0e3ae711807183700ebf2e4633e4"

globals@^6.4.1:
version "6.4.1"
resolved "https://registry.yarnpkg.com/globals/-/globals-6.4.1.tgz#8498032b3b6d1cc81eebc5f79690d8fe29fabf4f"
globals@^11.3.0:
version "11.7.0"
resolved "https://registry.yarnpkg.com/globals/-/globals-11.7.0.tgz#a583faa43055b1aca771914bf68258e2fc125673"

globals@^9.18.0:
version "9.18.0"
Expand Down Expand Up @@ -3345,7 +3345,7 @@ https-proxy-agent@^2.1.1:
agent-base "^4.1.0"
debug "^3.1.0"

hunspell-spellchecker@^1.0.0:
hunspell-spellchecker@^1.0.2:
version "1.0.2"
resolved "https://registry.yarnpkg.com/hunspell-spellchecker/-/hunspell-spellchecker-1.0.2.tgz#a10b0bd2fa00a65ab62a4c6b734ce496d318910e"

Expand Down Expand Up @@ -4857,10 +4857,14 @@ [email protected], lodash@^4.0.0, lodash@^4.13.1, lodash@^4.14.0, lodash@^4.14.1, lod
version "4.17.4"
resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.4.tgz#78203a4d1c328ae1d86dca6460e369b57f4055ae"

lodash@^3.3.1, lodash@^3.5.0:
lodash@^3.5.0:
version "3.10.1"
resolved "https://registry.yarnpkg.com/lodash/-/lodash-3.10.1.tgz#5bf45e8e49ba4189e17d482789dfd15bd140b7b6"

lodash@^4.14.2:
version "4.17.10"
resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.10.tgz#1b7793cf7259ea38fb3661d4d38b3260af8ae4e7"

lodash@^4.17.5:
version "4.17.5"
resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.5.tgz#99a92d65c0272debe8c96b6057bc8fbfa3bed511"
Expand Down

0 comments on commit 564545c

Please sign in to comment.