Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure pagination list is wrapped in a div. #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thomasbiddle
Copy link

I'm actually not sure how this gem worked prior - but Bootstrap specs
require that the pagination list is wrapped in a div, which has the
correct class applied to it.

Gem wasn't working for me without this - simply showed up as an unstyled
list.

I'm actually not sure how this gem worked prior - but Bootstrap specs
require that the pagination list is wrapped in a div, which has the
correct class applied to it.

Gem wasn't working for me without this - simply showed up as an unstyled
list.
@drueck
Copy link

drueck commented Nov 13, 2014

I just came across this project and am planning on using it. Thanks for the work!

@thomasbiddle Just wanted to comment that the pagination was wrapped in a div for Bootstrap 2, but with Bootstrap 3, the examples show it wrapped in a nav tag, and that's no longer an essential part of the component itself. The pagination class is now set on the ul instead of the containing div.

I think I'm going to wrap my usages of this in a nav tag, but as much as I think it would be nice to have that part of the renderer, I think it should maybe be left up to the individual user if they want to put the pagination ul inside any other container (nav or div or whatever)? What do you all think?

@thomasbiddle
Copy link
Author

@drueck That's a good point! Hadn't realized Bootstrap 3 changed that.

Is the class set on the ul tag, or the nav tag then? When I was using this as it was originally built it was setting the class on ul I believe, and wasn't working. If B3 is expecting it to be set on nav then there still would need to be a change otherwise you would get an unformatted list, no?

@drueck
Copy link

drueck commented Nov 14, 2014

The class is set on the ul tag in Bootstrap 3. See the current docs for pagination here: http://getbootstrap.com/components/#pagination

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants