Some comments

bootsoup · Sep 28, 2023 · 2599d32 · 2599d32
1 parent e2b00ca
commit 2599d32
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/contracts/PermissionedSet.sol b/contracts/PermissionedSet.sol
@@ -6,14 +6,7 @@ import {EIP712} from "./lib/EIP712.sol";
 
 error InvalidSignature();
 
-/**
-	@custom:benediction DEVS BENEDICAT ET PROTEGAT CONTRACTVS MEAM
-	@title Permissioned Set
-
-	TODO.
-
-	@custom:date September 27th, 2023.
-*/
+// TODO: natspec
 contract PermissionedSet is EIP712, Ownable {
     /// A constant hash of the claim operation's signature.
     // same typehash for wrappping and unwrapping

diff --git a/contracts/PermissionedToken.sol b/contracts/PermissionedToken.sol
@@ -10,6 +10,7 @@ import {SafeERC20} from "@openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
 error NotWhitelisted();
 error InvalidInterestRate();
 
+// TODO: natspec
 contract PermissionedToken is PermissionedSet, ReentrancyGuard, ERC20 {
     using SafeERC20 for ERC20;
 
@@ -80,6 +81,7 @@ contract PermissionedToken is PermissionedSet, ReentrancyGuard, ERC20 {
         // tokenMintAmount = 100 * 0.95 = 95
 
         // TODO: do we lose precision by dividing by 1e18??  What if interest rate is 5.5%?  then tokenMintAmount = 100 * 0.945 = 94.5
+        // or maybe it's okay because values are stored as wei?
 
         uint256 tokenMintAmount = (_usdcAmount * 1e18 * (1e18 - interestRateMantissa)) / 1e18;