[iOS] 여정 목록 헤더 & UserID 관련 로직 수정 #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
yoondj98
approved these changes
Dec 11, 2023
| import MSNetworking | ||
|
|
||
| public protocol UserRepository { | ||
|
|
||
| func createUser() async -> Result<UUID, Error> | ||
| func fetchUUID() throws -> UUID | ||
| func fetchUUID() -> UUID? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 작업 내역
📝 리뷰 노트
hitTest
hitTest를 사용해 터치 여부를 결정하고 있는데, cell이 헤더보다 밑에 위치해 겹치는 경우 cell이 터치되게 됩니다.때문에 cell이 터치된 경우에도 header가 영역에 존재하는지를 확인하는 로직을 추가했습니다.
UserID
기존에
fetchUUID메서드에fetch로직 뿐만 아니라 없을 경우 새로 생성하는 로직이 포함되어 있었는데,이것 때문에 착오가 생기지 않았을까 싶습니다.
해당 문제 수정해두었습니다.
DEBUG scheme
HomeViewModel의viewNeedsLoaded에서 수행하던 앱 정보 초기화 로직을SceneDelegate로 옮겼습니다.