-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] 여정 저장 Scene 비즈니스 로직 구현 #144
Merged
SwiftyJunnos
merged 42 commits into
iOS/epic/SaveJourney
from
iOS/task/SaveJourney-Business-Logic
Dec 4, 2023
Merged
[iOS] 여정 저장 Scene 비즈니스 로직 구현 #144
SwiftyJunnos
merged 42 commits into
iOS/epic/SaveJourney
from
iOS/task/SaveJourney-Business-Logic
Dec 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .DS_Store # iOS/Features/JourneyList/Package.swift # iOS/Features/SaveJourney/Package.swift # iOS/MusicSpot.xcworkspace/contents.xcworkspacedata # iOS/MusicSpot/MusicSpot.xcodeproj/project.pbxproj # iOS/commit
# Conflicts: # iOS/Features/JourneyList/Package.swift # iOS/MSCoreKit/Sources/MSNetworking/MSNetworking.swift # iOS/MSData/Package.swift # iOS/MusicSpot.xcworkspace/contents.xcworkspacedata # iOS/MusicSpot/MusicSpot.xcodeproj/project.pbxproj
# Conflicts: # iOS/Features/JourneyList/Package.swift # iOS/Features/JourneyList/Sources/JourneyList/File.swift # iOS/Features/JourneyList/Sources/JourneyList/Presentation/JourneyListViewModel.swift # iOS/Features/JourneyList/Sources/JourneyList/Song.swift # iOS/Features/JourneyList/Sources/JourneyList/Spot.swift # iOS/MSData/Resources/MockJourney.json # iOS/MSData/Sources/MSData/Repository/JourneyRepository.swift
# Conflicts: # iOS/MSCoreKit/Sources/MSNetworking/MSNetworking.swift
# Conflicts: # iOS/MSCoreKit/Sources/MSNetworking/MSNetworking.swift
# Conflicts: # iOS/MSData/Sources/MSData/Repository/JourneyRepository.swift
# Conflicts: # iOS/Features/JourneyList/Package.swift # iOS/Features/JourneyList/Sources/JourneyList/Model/DTOConvertor.swift # iOS/Features/JourneyList/Sources/JourneyList/Presentation/JourneyListViewController.swift # iOS/Features/JourneyList/Sources/JourneyList/Presentation/JourneyListViewModel.swift # iOS/Features/SaveJourney/Sources/SaveJourney/Journey.swift # iOS/MSCoreKit/Sources/MSNetworking/APIURL.swift # iOS/MSCoreKit/Tests/MSNetworkingTests/Mock/MockURLProtocol.swift # iOS/MSData/Sources/MSData/DTO/Fragment/SpotDTO.swift # iOS/MSData/Sources/MSData/DTO/JourneyDTO.swift # iOS/MSData/Sources/MSData/Repository/JourneyRepository.swift # iOS/MSData/Sources/MSData/Resources/MockJourney.json # iOS/MSData/Sources/MSData/Router/Journey/JourneyRouter+Body.swift # iOS/MSData/Sources/MSData/Router/Journey/JourneyRouter+Header.swift # iOS/MSData/Sources/MSData/Router/Journey/JourneyRouter+Method.swift # iOS/MSData/Sources/MSData/Router/Journey/JourneyRouter+URL.swift # iOS/MSData/Sources/MSData/Router/Journey/JourneyRouter.swift # iOS/MSUIKit/Sources/MSUIKit/Cells/JourneyCell/JourneyCell.swift # iOS/MusicSpot/MusicSpot.xcodeproj/project.pbxproj # iOS/MusicSpot/MusicSpot/SceneDelegate.swift
# Conflicts: # iOS/Features/SelectSong/Package.swift
SwiftyJunnos
changed the base branch from
iOS/release
to
iOS/epic/SaveJourney
December 4, 2023 15:00
PushedGun
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다. 🔥
yoondj98
approved these changes
Dec 4, 2023
} | ||
|
||
@objc | ||
private func handlePanGesture(_ sender: UIPanGestureRecognizer) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
panGesture, handleGesture 사용법 학습해봐야겠습니다.
고생 많으셨습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ 배경
close #105
🔧 작업 내역
🧪 테스트 방법
📝 리뷰 노트
Spot
Spot을 기존의 JourneyListCell을 재활용하던 코드에서 단일 사진을 사용하는 SpotCell을 추가해 적용했습니다.
AlertViewController
사진의 컴포넌트를 추가했습니다.
가운데 TextField를 제외한 Title, subtitle, 버튼 두개가 기본 요소입니다.
📸 스크린샷