Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] 여정 저장 Scene 비즈니스 로직 구현 #144

Merged

Conversation

SwiftyJunnos
Copy link
Member

@SwiftyJunnos SwiftyJunnos commented Nov 30, 2023

❗ 배경

작업 배경에 대한 설명을 작성합니다.
Issue에 대한 링크를 첨부합니다.

close #105

🔧 작업 내역

작업한 내용들을 나열합니다.
간결하게 리스트 업하고, 자세한 설명은 아래 리뷰 노트에서 합니다.

  • UI 변경
  • AlertViewController 추가 및 적용

🧪 테스트 방법

동작을 테스트할 수 있는 방법을 설명합니다.
앱 실행 방법일 수 있고, 유닛 테스트 실행 방법일 수 있습니다.

📝 리뷰 노트

작업 내역에 대한 자세한 설명을 작성합니다.

Spot

Spot을 기존의 JourneyListCell을 재활용하던 코드에서 단일 사진을 사용하는 SpotCell을 추가해 적용했습니다.

AlertViewController

Screenshot 2023-12-04 at 23 29 23

사진의 컴포넌트를 추가했습니다.
가운데 TextField를 제외한 Title, subtitle, 버튼 두개가 기본 요소입니다.

📸 스크린샷

작업한 내용에 대한 스크린샷, 영상 등을 첨부합니다.

데모 영상

PushedGun and others added 6 commits November 27, 2023 17:09
# Conflicts:
#	.DS_Store
#	iOS/Features/JourneyList/Package.swift
#	iOS/Features/SaveJourney/Package.swift
#	iOS/MusicSpot.xcworkspace/contents.xcworkspacedata
#	iOS/MusicSpot/MusicSpot.xcodeproj/project.pbxproj
#	iOS/commit
@SwiftyJunnos SwiftyJunnos added the ✨ 신규 기능 신규 기능 개발 label Nov 30, 2023
@SwiftyJunnos SwiftyJunnos self-assigned this Nov 30, 2023
@SwiftyJunnos SwiftyJunnos changed the base branch from main to iOS/epic/SaveJourneyScene November 30, 2023 06:48
# Conflicts:
#	iOS/Features/JourneyList/Package.swift
#	iOS/MSCoreKit/Sources/MSNetworking/MSNetworking.swift
#	iOS/MSData/Package.swift
#	iOS/MusicSpot.xcworkspace/contents.xcworkspacedata
#	iOS/MusicSpot/MusicSpot.xcodeproj/project.pbxproj
# Conflicts:
#	iOS/Features/JourneyList/Package.swift
#	iOS/Features/JourneyList/Sources/JourneyList/File.swift
#	iOS/Features/JourneyList/Sources/JourneyList/Presentation/JourneyListViewModel.swift
#	iOS/Features/JourneyList/Sources/JourneyList/Song.swift
#	iOS/Features/JourneyList/Sources/JourneyList/Spot.swift
#	iOS/MSData/Resources/MockJourney.json
#	iOS/MSData/Sources/MSData/Repository/JourneyRepository.swift
# Conflicts:
#	iOS/MSCoreKit/Sources/MSNetworking/MSNetworking.swift
# Conflicts:
#	iOS/MSCoreKit/Sources/MSNetworking/MSNetworking.swift
# Conflicts:
#	iOS/MSData/Sources/MSData/Repository/JourneyRepository.swift
Base automatically changed from iOS/epic/SaveJourneyScene to iOS/release November 30, 2023 16:43
# Conflicts:
#	iOS/Features/JourneyList/Package.swift
#	iOS/Features/JourneyList/Sources/JourneyList/Model/DTOConvertor.swift
#	iOS/Features/JourneyList/Sources/JourneyList/Presentation/JourneyListViewController.swift
#	iOS/Features/JourneyList/Sources/JourneyList/Presentation/JourneyListViewModel.swift
#	iOS/Features/SaveJourney/Sources/SaveJourney/Journey.swift
#	iOS/MSCoreKit/Sources/MSNetworking/APIURL.swift
#	iOS/MSCoreKit/Tests/MSNetworkingTests/Mock/MockURLProtocol.swift
#	iOS/MSData/Sources/MSData/DTO/Fragment/SpotDTO.swift
#	iOS/MSData/Sources/MSData/DTO/JourneyDTO.swift
#	iOS/MSData/Sources/MSData/Repository/JourneyRepository.swift
#	iOS/MSData/Sources/MSData/Resources/MockJourney.json
#	iOS/MSData/Sources/MSData/Router/Journey/JourneyRouter+Body.swift
#	iOS/MSData/Sources/MSData/Router/Journey/JourneyRouter+Header.swift
#	iOS/MSData/Sources/MSData/Router/Journey/JourneyRouter+Method.swift
#	iOS/MSData/Sources/MSData/Router/Journey/JourneyRouter+URL.swift
#	iOS/MSData/Sources/MSData/Router/Journey/JourneyRouter.swift
#	iOS/MSUIKit/Sources/MSUIKit/Cells/JourneyCell/JourneyCell.swift
#	iOS/MusicSpot/MusicSpot.xcodeproj/project.pbxproj
#	iOS/MusicSpot/MusicSpot/SceneDelegate.swift
@SwiftyJunnos SwiftyJunnos marked this pull request as ready for review December 4, 2023 14:22
@SwiftyJunnos SwiftyJunnos changed the base branch from iOS/release to iOS/epic/SaveJourney December 4, 2023 15:00
Copy link
Member

@PushedGun PushedGun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다. 🔥

}

@objc
private func handlePanGesture(_ sender: UIPanGestureRecognizer) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

panGesture, handleGesture 사용법 학습해봐야겠습니다.
고생 많으셨습니다.

@SwiftyJunnos SwiftyJunnos merged commit 4aed2fe into iOS/epic/SaveJourney Dec 4, 2023
31 checks passed
@SwiftyJunnos SwiftyJunnos deleted the iOS/task/SaveJourney-Business-Logic branch December 4, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ 신규 기능 신규 기능 개발
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SaveJourney Scene 비즈니스 로직 구현
3 participants