Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature #191: playwright 적용해서 e2e 테스트하기 #203

Merged
merged 12 commits into from
Dec 4, 2024
Merged

Feature #191: playwright 적용해서 e2e 테스트하기 #203

merged 12 commits into from
Dec 4, 2024

Conversation

naarang
Copy link
Collaborator

@naarang naarang commented Dec 3, 2024 •
edited
Loading

#️⃣연관된 이슈

closed #191

📝작업 내용

  • mockRepository에 검색 기능, 페이지네이션 최대 페이지 개수 계산하기 추가
  • mock에서 불필요한 함수 제거 및 네이밍 맞추기
  • playwright 적용해서 e2e 테스트하기
  • lotus 삭제 시 invalidateQuery하기

스크린샷 (선택)

image

2024-12-04.11.01.38.mov

💬리뷰 요구사항(선택)

  • 테스트 코드를 src > app > test > e2e 에다가 넣어놨는데 괜찮을까요?
  • 더 필요한 테스트 케이스가 있을까요?

naarang added 12 commits December 3, 2024 00:38
@naarang
feat(#191): playwright 설치하기
8d0bdbf
@naarang
Merge branch 'main' of https://github.com/boostcampwm-2024/web38-Froxy …
b966ccf 
…into feature-#191-playwright
@naarang
feat(#191): playwright로 간단히 테스트해보기
559a5f3
@naarang
refactor(#191): mock 변경 사항 반영 및 불필요한 resolver 제거 및 resolver 함수명 통일하기
b1e238f
@naarang
refactor(#191): mock history 불필요한 함수 제거 및 DTO 적용하기
81dc669
@naarang
refactor(#191): mock lotus 제목 검색 로직 추가하기
816b8a1
@naarang
Merge branch 'main' of https://github.com/boostcampwm-2024/web38-Froxy …
055b1bb 
…into feature-#191-playwright
@naarang
refactor(#191): mocking 시에 페이지네이션 max 값도 계산하기
231eaa5
@naarang
refactor(#191): user에 대한 MockRepository 적용하기
d3d3098
@naarang
refactor(#191): 테스트를 위한 data-testid값을 부여
dd97ad1
@naarang
fix(#191): lotus 삭제 시 오류 수정하기
d178a4e
@naarang
refactor(#191): app 레이어로 테스트 코드 이동 및 e2e 테스트 코드 작성완료
ca8d710
@naarang naarang self-assigned this Dec 3, 2024
@naarang naarang requested a review from ATeals December 3, 2024 16:06
ATeals
ATeals approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@ATeals ATeals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니당 playwright 글도 작성해주세용 ㅎㅎ 저도 너무 몰라서 말이죠

@naarang naarang merged commit 8519406 into main Dec 4, 2024
2 checks passed
@naarang naarang deleted the feature-#191-playwright branch December 4, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ATeals ATeals ATeals approved these changes

Assignees

@naarang naarang

Labels
💻 Fe ✨ Feature ♻️ Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

playwright로 E2E 테스트하기
2 participants
@naarang @ATeals