Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/client/#169 #171

Merged
merged 6 commits into from
Dec 2, 2024
Merged

Fix/client/#169 #171

merged 6 commits into from
Dec 2, 2024

Conversation

p1n9d3v
Copy link
Collaborator

@p1n9d3v p1n9d3v commented Dec 1, 2024

연관 이슈

#169
#170

주요 작업

  • 128x111 크기가 넘어가는 노드에 대해서 그룹화 크기의 버그 수정
  • 3d에서 노드의 크기가 상이함에 따라 그룹화의 크기의 오차 수정
  • zoom 제한 설정
  • 3d connector pointer 위치 변경

구현 결과

Screen.Recording.2024-12-01.at.9.21.50.PM.mov
Screen.Recording.2024-12-01.at.9.21.26.PM.mov

비고(Optional)

3d connector의 위치를 svg의 베이스 포인트를 잡고 하긴 했는데 128x111 배수가 아니라면 connector의 위치가 애매함. 128x111 의 배수이면 connector pointer가 딱 들어맞지만 좀 작은 사이즈에 관해서는 애매한 것이 있음 추후 변경 예정

Copy link
Collaborator

@SeoGeonhyuk SeoGeonhyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SeoGeonhyuk SeoGeonhyuk merged commit b7b0640 into development Dec 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants