Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into Feature/#171_한글_crdt_연동되도록_구현
minjungw00
approved these changes
Nov 23, 2024
hyonun321
approved these changes
Nov 24, 2024
|
|
||
| characters.forEach((char, index) => { | ||
| const insertPosition = startPosition + index; | ||
| const charNode = block.crdt.localInsert(insertPosition, char, block.id, pageId); |
There was a problem hiding this comment.
최곱니다!! 배포가 너무 기대됩니다.
노션을 읽기전까지는 한글 -> ['한','글'] 로 받아와서 각각 로컬 insert를 진행하는 코드인줄 알았습니다.
올려주신 노션을 보니까 "한." 이 들어온다면 ['한','.'] 이렇게 2개가 들어올 것이고, 띄어쓰기나 ',' '.' 도 컴포징 될때 포함되는데 이것도 들어가는걸까요?
그렇다면
한글.
을 입력할때
['한']
['글'',.']
여기서 localInsert가 진행돼서
한글.
이렇게 입력되는게 맞나요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 변경 사항
🔍 변경 사항 설명
🙏 질문 사항
📷 스크린샷 (선택)
2024-11-22.10.17.53.mov
✅ 작성자 체크리스트