검색 API 구현 #319
Merged
검색 API 구현 #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Application Server의 search api를 추가함에 따라 path alias를 추가했습니다.
Application Server에서 Search 모듈에서 사용할 조건별 멤버 검색 함수를 작성하였습니다.
검색에 대한 정보 제공을 위한 Application Server의 API를 추가하였습니다. 사용방법: [GET] api.funch.site/search?query=검색어
Closed
zzawang
approved these changes
Dec 2, 2024
| SearchModule, | ||
| FollowModule, | ||
| NaverAuthModule, | ||
| GoogleAuthModule, |
| @@ -12,19 +12,25 @@ class MemberService { | |||
| private memberRepository: Repository<Member>, | |||
| ) {} | |||
|
|
|||
| async findMembers() { | |||
| findMembers() { | |||
applicationServer/src/app.module.ts
Outdated
| @@ -6,13 +6,23 @@ import { LiveModule } from '@live/live.module'; | |||
| import { GithubAuthModule } from '@github/github.module'; | |||
| import { AuthModule } from '@auth/auth.module'; | |||
| import { FollowModule } from '@follow/follow.module'; | |||
| import { SearchModule } from './search/search.module'; | |||
| @@ -0,0 +1,32 @@ | |||
| import { Controller, Get, Query } from '@nestjs/common'; | |||
| import { SearchService } from './search.service'; | |||
| const keyword = query.replace(' ', ''); | ||
| const searchResult = { | ||
| lives: [], | ||
| members: [], |
There was a problem hiding this comment.
이것도 on/off 같이 변수명을 더 직관적이게 만들면 좋을 것 같아요.
하지만 오전에 FE분들이랑 이미 명세에 관해서 얘기 나눠서 괜찮을 것 같네요!
|
|
||
| @Get('/') | ||
| async getSearchData(@Query('query') query: string) { | ||
| const keyword = query.replace(' ', ''); |
There was a problem hiding this comment.
검색 효율성을 위해 공백을 제거한 문자열 매칭으로 탐색하기 때문에 검색어에서도 공백을 제거했습니다.
|
|
||
| getLiveListWithKeyword(keyword) { | ||
| const currentLiveList = this.liveService.getLiveList(0); | ||
| const filteredLiveList = currentLiveList.reduce((list, live) => { |
There was a problem hiding this comment.
진영님 정말 reduce를 좋아하시고 또 잘 쓰시네요..!!
| const metadata = [...live.tags, live.contentCategory, live.moodCategory, live.title, live.userName] | ||
| .join('') | ||
| .replace(' ', ''); | ||
| if (metadata.match(new RegExp(keyword))) list.push(live); |
There was a problem hiding this comment.
아까 개발일지를 봤었는데, kmp 알고리즘과 정규표현식의 비교를 통해 정규표현식으로 결정하셨네요!
비교까지 👍🏻👍🏻 좋습니다!
There was a problem hiding this comment.
사실 kmp가 당연히 더 빠를 줄 알았는데 느려서 조금 당황스럽긴 하네요..
Application Server의 search 모듈에서 import에 path alias를 적용하도록 변경하였습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Detail
추가했습니다.
작성하였습니다.
사용방법:
[GET] api.funch.site/search?query=검색어