Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] 티클 종료 status 변경 시점 변경 #384

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

simeunseo
Copy link
Collaborator

관련 이슈 번호

작업 내용

  • 창 닫기를 눌렀을 때 컨펌창에 확인을 누르기 전에 종료 요청과 소켓 연결해제가 발생하는 문제가 잇었음
  • beforeunload가 아닌 unload 이벤트를 사용하여 창이 완전히 닫힌 후에 종료 요청과 소켓 연결 해제를 하도록 수정

PR 포인트

고민과 학습내용

스크린샷

@simeunseo simeunseo added FE Frontend 관련 작업 ✨ Feature 새로운 기능 추가 labels Dec 5, 2024
@simeunseo simeunseo self-assigned this Dec 5, 2024
@github-actions github-actions bot added the size/s label Dec 5, 2024
Copy link

github-actions bot commented Dec 5, 2024

🎨 스토리북 확인하기

@simeunseo simeunseo merged commit ffab126 into develop Dec 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FE Frontend 관련 작업 ✨ Feature 새로운 기능 추가 size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fix] 티클 종료 status 변경 시점 변경
3 participants