-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Observer Pattern을 통한 Toast Message 추가 #349
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- mount, unmount 시점에 등록된 callback 함수를 실행
- setTimeout을 통해 일정 시간 후에 closeToast 함수 호출
seoko97
requested review from
begong313,
simeunseo,
Jieun1ee and
Fixtar
as code owners
December 2, 2024 15:09
🎨 스토리북 확인하기
|
begong313
approved these changes
Dec 3, 2024
simeunseo
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈 번호
작업 내용
toast
메서드 실행시 ReactNode를 인자로 넘겨 렌더링 실행PR 포인트
문서화를 진행하였습니다.
스크린샷
toast
함수의 인자로 ReactNode Type을 넘겨서 실행할 수 있습니다.