[Feat] Peer 접속시 UI 상에 Dummy User 반영 #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seoko97
requested review from
begong313,
simeunseo,
Jieun1ee and
Fixtar
as code owners
🎨 스토리북 확인하기
|
begong313
approved these changes
Dec 2, 2024
| @@ -267,7 +265,7 @@ export class MediasoupService implements OnModuleInit { | |||
| const peer = room.peers.get(socketId); | |||
| const consumer = peer.getConsumer(consumerId); | |||
|
|
|||
| consumer.pause(); | |||
| consumer?.pause(); | |||
There was a problem hiding this comment.
P3 어제 제가 올린 에러 해결된거 확인하였습니다!! ? 없이도 에러가 나지 않던데 없에도 되지않을까요??
simeunseo
approved these changes
Dec 2, 2024
Fixtar
approved these changes
Dec 2, 2024
Jieun1ee
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈 번호
작업 내용
PR 포인트
현재
newProducer이벤트를 통해 consumer를 생성하고 있기 때문에 만약 이미 더미 유저가 존재하고 새롭게 접속하는 유저는 기존 더미유저를 받아오지 못합니다.해당 부분을 해결하기 위해선 전체적인 리펙토링이 필요하기 때문에 기존 유저가 새로운 peer가 접속했을 때 더미 유저가 추가되는 방향으로 구현을 진행하였습니다.
스크린샷