[Feat] logger 적용 #333
Merged
[Feat] logger 적용 #333
+576
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixtar
requested review from
seoko97,
begong313,
simeunseo and
Jieun1ee
as code owners
Jieun1ee
approved these changes
Dec 2, 2024
Comment on lines
23
to
28
|
|
||
| console.log('today : ', today); | ||
| const logFileName = `application-${today.toISOString().split('T')[0]}.log`; | ||
| const localFilePath = path.join(logsDir, logFileName); | ||
|
|
||
| console.log('localFilePath : ', localFilePath); |
There was a problem hiding this comment.
p3 : 필요없는 log나 주석은 삭제해주셔도 좋을 것 같아요~!
There was a problem hiding this comment.
p1:
서버측에 로그 생성시 생성되었다는 것을 알리기 위해 console.log를 사용하신 걸까요??
현재 lint 상에 console.log는 오류가 발생하도록 되어있어 CI/CD시 오류가 발생할 것으로 보입니다
There was a problem hiding this comment.
헉 테스트하고 그대로 뒀습니다 삭제하겠습니다~!
|
|
||
| try { | ||
| const uploadResponse = await this.s3.send(new PutObjectCommand(params)); | ||
| // console.log('File uploaded:', uploadResponse); |
begong313
approved these changes
Dec 2, 2024
apps/api/src/app.module.ts
Outdated
| import { ConfigModule } from '@nestjs/config'; | ||
| import { ScheduleModule } from '@nestjs/schedule'; |
There was a problem hiding this comment.
p3 사용하지않는 IMPORT 제거부탁드립니다!
seoko97
requested changes
Dec 2, 2024
Comment on lines
23
to
28
|
|
||
| console.log('today : ', today); | ||
| const logFileName = `application-${today.toISOString().split('T')[0]}.log`; | ||
| const localFilePath = path.join(logsDir, logFileName); | ||
|
|
||
| console.log('localFilePath : ', localFilePath); |
There was a problem hiding this comment.
p1:
서버측에 로그 생성시 생성되었다는 것을 알리기 위해 console.log를 사용하신 걸까요??
현재 lint 상에 console.log는 오류가 발생하도록 되어있어 CI/CD시 오류가 발생할 것으로 보입니다
seoko97
approved these changes
Dec 2, 2024
simeunseo
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈 번호
작업 내용
PR 포인트
고민과 학습내용
winston logger를 추가하였습니다. 모든 api 요청에 대해 log를 남기도록 했습니다.
logger를 모듈로 분리하여 각각의 모듈에서 import 하여 사용할 수 있습니다.
winston을 매일 1개의 .log 파일을 생성하도록 설정하였습니다.
따라서 이 Log파일을 batch를 이용하여 매일 1번씩 Object Storage로 업로드 하도록 구현하였습니다.
스크린샷