Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] 비디오에 nickname 표시 #317

Merged
merged 13 commits into from
Nov 28, 2024
Merged

Conversation

simeunseo
Copy link
Collaborator

관련 이슈 번호

작업 내용

  • stream관련 인터페이스에 nickname 타입 추가
  • VideoPlayer에 nickname prop을 넘겨줌
  • localStream의 경우 전역 상태에 있는 nickname을 가져와서 넘겨줌

PR 포인트

고민과 학습내용

스크린샷

스크린샷 2024-11-28 오후 12 32 17

@simeunseo simeunseo added FE Frontend 관련 작업 ✨ Feature 새로운 기능 추가 labels Nov 28, 2024
@simeunseo simeunseo self-assigned this Nov 28, 2024
Copy link

github-actions bot commented Nov 28, 2024

🎨 스토리북 확인하기

Copy link
Collaborator

@begong313 begong313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☺️

@begong313 begong313 merged commit c827857 into develop Nov 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FE Frontend 관련 작업 ✨ Feature 새로운 기능 추가 size/l
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] 비디오 그리드에 닉네임 보여주기
3 participants