-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] 비디오에 nickname 표시 #317
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simeunseo
requested review from
seoko97,
begong313,
Jieun1ee and
Fixtar
as code owners
November 28, 2024 03:41
🎨 스토리북 확인하기
|
begong313
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixtar
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈 번호
작업 내용
PR 포인트
[Feat] 인증 정보를 전역 상태로 관리, 로그인 필요한 페이지에 접속시 로그인 페이지로 리다이렉트 #311
위 PR에 의존성이 있어서 브랜치 체이닝을 했습니다!
feat: nickname type 추가
커밋부터 이 PR의 작업내용입니다.혹시 nickname 필드가 들어가지 않아도되는 곳에 들어갔다거나 기존 로직에 영향을 미치는부분이 있다면 확인해주시기 바랍니다!!!
고민과 학습내용
스크린샷