[Feat] 프로필 정보 UI 구현 #294
Merged
[Feat] 프로필 정보 UI 구현 #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simeunseo
requested review from
seoko97,
begong313,
Jieun1ee and
Fixtar
as code owners
🎨 스토리북 확인하기
|
begong313
approved these changes
Nov 27, 2024
Jieun1ee
approved these changes
Nov 27, 2024
Fixtar
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈 번호
작업 내용
PR 포인트
브랜치 체이닝으로 인해 commit 이 섞여있습니다 😭
feat: Provider 타입 안정성 강화 및 공통 타입으로 분리부터 이번 커밋입니다...로그인 여부에 따른 헤더 UI 분기처리 '임시처리'
제 생각에 로그인 여부를 전역상태로 관리해야할 것 같은데, 이 부분 석호님이랑 이야기해봐야할거같아서
일단 임시로 유저 정보 GET 날렸을 때 401 에러 반환되면 로그인 안된 것으로 보고 그걸 기준으로 분기처리를 했습니다.
추후 수정예정입니다.
로그아웃
로그아웃이 아직 구현되지 않았습니다. 좀전에 종빈님이 구현해주신거 머지한다음에 추후 합칠 예정입니다!
고민과 학습내용
스크린샷
깃헙로그인, 구글로그인, 게스트로그인 (로그아웃이 없어서 직접 쿠키삭제)
2024-11-27.1.02.36.mov
남의 프로필 조회
2024-11-27.1.11.30.mov