[Feat] 유저 정보 조회 API 구현 #288
Merged
+288
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simeunseo
requested review from
seoko97,
begong313,
Jieun1ee and
Fixtar
as code owners
🎨 스토리북 확인하기
|
Fixtar
approved these changes
Nov 26, 2024
begong313
reviewed
Nov 26, 2024
apps/api/src/user/user.controller.ts
Outdated
| @@ -1,12 +1,22 @@ | |||
| import { Controller, Get, Patch } from '@nestjs/common'; | |||
| import { Controller, Get, Param, Patch, UseGuards } from '@nestjs/common'; | |||
There was a problem hiding this comment.
p3 안쓰는 import만 제거하고 머지하시면될거같습니다!
begong313
approved these changes
Nov 26, 2024
seoko97
approved these changes
Nov 26, 2024
Comment on lines
+84
to
+89
| const user = await this.userRepository | ||
| .createQueryBuilder('user') | ||
| .leftJoin('user.ticles', 'ticles') | ||
| .addSelect('ticles.title') | ||
| .where('user.id = :userId', { userId: userId }) | ||
| .getOne(); |
There was a problem hiding this comment.
Q:
TypeORM의 find({relations})와 동일한 결과 값을 반환할 것 같은데 queryBuilder를 사용하신 이유가 있을까요?
Comment on lines
+96
to
+102
| return { | ||
| id: user.id, | ||
| nickname: user.nickname, | ||
| profileImageUrl: user.profileImageUrl, | ||
| provider: user.provider, | ||
| ticles: ticles.map((ticle) => ticle.title), | ||
| }; |
There was a problem hiding this comment.
p5:
만약 QueryBuilder를 사용하는게 목적이라면 QueryBuilder를 통해 직접 조회하는 것도 좋을 것 같습니다! (학습 목적으로)
Jieun1ee
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈 번호
작업 내용
PR 포인트
백엔드 팀원들의 도움을 받아서 구현했습니다.
고민과 학습내용
스크린샷