Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] Type ORM 환경변수 세팅 #110

Merged
merged 7 commits into from
Nov 6, 2024
Merged

[Feat] Type ORM 환경변수 세팅 #110

merged 7 commits into from
Nov 6, 2024

Conversation

begong313
Copy link
Collaborator

@begong313 begong313 commented Nov 6, 2024 •
edited
Loading

관련 이슈 번호

작업 내용

  • nest/config를 사용하여 환경변수 사용

PR 포인트

고민과 학습내용

  • 석호님의 피드백을 반영하기 위해서 nestjs/config사용법을 공부하였음
  • 트러블슈팅 노션 링크
  • 요약
    • nest에 대한 지식부족으로 코드를 모른 체 사용하고 있었음.
    • 피드백 전 코드도 틀린것은 아니나, 현재로썬 굳이 저렇게 사용 할 필요 없었음

스크린샷

  • 연결 후 db가 정상적으로 생성 된 모습
스크린샷 2024-11-06 오전 11 51 42 스크린샷 2024-11-06 오후 12 02 08

@begong313 begong313 added BE Backend 관련 작업 🔨 Config 환경 설정 작업 labels Nov 6, 2024
@begong313 begong313 added this to the 통합 개발 환경 구축 milestone Nov 6, 2024
@begong313 begong313 self-assigned this Nov 6, 2024
@github-actions github-actions bot added the size/m label Nov 6, 2024
simeunseo
simeunseo approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@simeunseo simeunseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

환경변수 관련해서 트러블 슈팅 하셨던 과정 인상적이었는데, PR에 링크 해주시면 좋지 않을까 싶습니다~!!

추가로 postcss esmodule 관련해서 임시로 에러 해결해주셨던 것이 제 PR과 conflict나는 부분이 있어서 제가 간단히 resolve해두었습니다!

고생하셨습니다!!!

apps/api/config/typeorm.config.ts Outdated Show resolved Hide resolved
apps/api/src/app.module.ts Outdated Show resolved Hide resolved
Fixtar
Fixtar approved these changes Nov 6, 2024
View reviewed changes
apps/api/config/typeorm.config.ts Outdated Show resolved Hide resolved
@begong313 begong313 merged commit 7382e0c into develop Nov 6, 2024
1 check passed
@begong313 begong313 deleted the feat/#105/env-setting branch December 5, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fixtar Fixtar Fixtar approved these changes

@simeunseo simeunseo simeunseo approved these changes

@seoko97 seoko97 Awaiting requested review from seoko97 seoko97 is a code owner

@Jieun1ee Jieun1ee Awaiting requested review from Jieun1ee Jieun1ee is a code owner

Assignees

@begong313 begong313

Labels
BE Backend 관련 작업 🔨 Config 환경 설정 작업 size/m
Projects
None yet
Milestone
통합 개발 환경 구축
Development

Successfully merging this pull request may close these issues.

[Feat] Nest JS TypeORM 환경변수 설정
3 participants
@begong313 @simeunseo @Fixtar