[Feat] api endpoint 목록 작성 #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixtar
requested review from
seoko97,
begong313,
simeunseo and
Jieun1ee
as code owners
seoko97
requested changes
Nov 5, 2024
apps/api/src/auth/auth.controller.ts
Outdated
Comment on lines
13
to
16
| @Get('profile') | ||
| profile() { | ||
| return 'profile'; | ||
| } |
There was a problem hiding this comment.
p3:
user profile에 대한 정보를 가져오는 것으로 보입니다. 해당 정보가 Auth Controller에 정의되는 것이 아닌 User에 정의되어야 하지 않을까 생각합니다
apps/api/src/auth/auth.controller.ts
Outdated
Comment on lines
18
to
19
| @Patch('/profile') | ||
| patchProfile() {} |
There was a problem hiding this comment.
p3:
user profile에 대한 정보를 가져오는 것으로 보입니다. 해당 정보가 Auth Controller에 정의되는 것이 아닌 User에 정의되어야 하지 않을까 생각합니다
p1:
/ prefix 를 여기서만 붙이고 있는데 통일을 위해 제거해주세요!
|
|
||
| @Controller('ticle') | ||
| export class TicleController { | ||
| @Post('') |
There was a problem hiding this comment.
p1:
endpoint가 /일 경우 빈 값을 넣어도 좋습니다
Suggested change
| @Post('') | |
| @Post() |
| getSearchList() {} | ||
|
|
||
| @Get(':ticleId/apply') | ||
| applyTicle(@Param('ticleId') params: any) {} |
There was a problem hiding this comment.
applyTicle 메서드는 정확하게 어떤 역할을 하나요? 의미가 모호한 것 같습니다!
| getTicleList(@Query('filter') filter?: string, @Query('sort') sort?: string) {} | ||
|
|
||
| @Get('search') | ||
| getSearchList() {} |
There was a problem hiding this comment.
p2:
다른 메서드들과 통일을 위해 Ticle이란 키워드를 붙여주세요!
api 분리와 api 경로를 통일성있게 변경
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈 번호
close #79
작업 내용
PR 포인트
고민과 학습내용
예를 들어 스트리밍중 카메라 on/off 와 같은 기능들은 api 서버를 타게 되는지 아직 정해지지 않아 작성하지 않았습니다.
스크린샷