Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release to Main #292

Merged
merged 145 commits into from
Nov 29, 2024
Merged

Release to Main #292

merged 145 commits into from
Nov 29, 2024

Conversation

DongHoonYu96
Copy link
Collaborator

  • 제목 : [BE/FE] feat#이슈번호 기능명
    ex) [BE] feat#156 자동배포 구현
    (확인 후 지워주세요)

➕ 이슈 번호

  • #이슈번호

🔎 작업 내용

  • 작업 내용을 설명해주세요

🖼 참고 이미지


🎯 리뷰 요구사항 (선택)

  • 특별히 봐줬으면 하는 부분이 있다면 적어주세요

✅ Check List

  • merge할 브랜치의 위치를 확인했나요?
  • Label을 지정했나요?

NewCodes7 and others added 30 commits November 22, 2024 20:48
todo : 재입장 불가
최상단 import 해야함에 주의
이래야 mysql, 함수 콜스택 지원
[FE] feat#30 강퇴 기능 구현 및 채팅렌더링 최적화
NewCodes7 and others added 24 commits November 28, 2024 11:49
fix: 깃 충돌 해결하기 위해 미리 변경사항 반영
client.id는 소켓의 uuid, room.host에는 쿠키값이 저장되어 있었음
기존방의플레이어에게 새로운 플레이어 알림 / 새 플레이어에게 기존방의 플레이어들 알림
[BE] fix: [BE] 강퇴시 kickRoom event 발송, 선택지 동적결정, joinRoom시 host여부 전송
[BE] fix: CORS Origin 설정 및 쿠키 SameSite, Secure 옵션 추가
@DongHoonYu96 DongHoonYu96 requested a review from Copilot November 29, 2024 07:09

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 103 out of 117 changed files in this pull request and generated no suggestions.

Files not reviewed (14)
  • BE/package.json: Language not supported
  • BE/src/game/redis/redis-subscriber.service.ts: Evaluated as low risk
  • BE/src/common/constants/redis-key.constant.ts: Evaluated as low risk
  • BE/src/game/game.module.ts: Evaluated as low risk
  • BE/src/common/constants/exception-message.ts: Evaluated as low risk
  • BE/src/game/dto/create-game.dto.ts: Evaluated as low risk
  • BE/src/game/dto/update-room-option.dto.ts: Evaluated as low risk
  • BE/src/common/constants/socket-events.ts: Evaluated as low risk
  • BE/.eslintrc.js: Evaluated as low risk
  • .github/workflows/deploy.yml: Evaluated as low risk
  • BE/src/common/filters/ws-exception.filter.ts: Evaluated as low risk
  • BE/src/common/constants/game-mode.ts: Evaluated as low risk
  • BE/src/game/game.gateway.ts: Evaluated as low risk
  • BE/src/game/dto/set-player-name.dto.ts: Evaluated as low risk
@DongHoonYu96 DongHoonYu96 merged commit e18feae into main Nov 29, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants