-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release to Main #292
Merged
Merged
Release to Main #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: JunWoo Park <[email protected]>
[FE] refactor fe directory
todo : 재입장 불가
최상단 import 해야함에 주의
이래야 mysql, 함수 콜스택 지원
[FE] feat#30 강퇴 기능 구현 및 채팅렌더링 최적화
fix: 깃 충돌 해결하기 위해 미리 변경사항 반영
[BE] Dev be -> release
client.id는 소켓의 uuid, room.host에는 쿠키값이 저장되어 있었음
[BE] hotfix#3
Dev be to release
기존방의플레이어에게 새로운 플레이어 알림 / 새 플레이어에게 기존방의 플레이어들 알림
[BE] fix: [BE] 강퇴시 kickRoom event 발송, 선택지 동적결정, joinRoom시 host여부 전송
[BE] fix: CORS Origin 설정 및 쿠키 SameSite, Secure 옵션 추가
Dev be to release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 103 out of 117 changed files in this pull request and generated no suggestions.
Files not reviewed (14)
- BE/package.json: Language not supported
- BE/src/game/redis/redis-subscriber.service.ts: Evaluated as low risk
- BE/src/common/constants/redis-key.constant.ts: Evaluated as low risk
- BE/src/game/game.module.ts: Evaluated as low risk
- BE/src/common/constants/exception-message.ts: Evaluated as low risk
- BE/src/game/dto/create-game.dto.ts: Evaluated as low risk
- BE/src/game/dto/update-room-option.dto.ts: Evaluated as low risk
- BE/src/common/constants/socket-events.ts: Evaluated as low risk
- BE/.eslintrc.js: Evaluated as low risk
- .github/workflows/deploy.yml: Evaluated as low risk
- BE/src/common/filters/ws-exception.filter.ts: Evaluated as low risk
- BE/src/common/constants/game-mode.ts: Evaluated as low risk
- BE/src/game/game.gateway.ts: Evaluated as low risk
- BE/src/game/dto/set-player-name.dto.ts: Evaluated as low risk
songbuild00
approved these changes
Nov 29, 2024
NewCodes7
approved these changes
Nov 29, 2024
ijun17
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ex) [BE] feat#156 자동배포 구현
(확인 후 지워주세요)
➕ 이슈 번호
🔎 작업 내용
🖼 참고 이미지
🎯 리뷰 요구사항 (선택)
✅ Check List