Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] fix: [BE] 강퇴시 kickRoom event 발송, 선택지 동적결정, joinRoom시 host여부 전송 #288

Merged
merged 7 commits into from
Nov 28, 2024

Conversation

DongHoonYu96
Copy link
Collaborator

@DongHoonYu96 DongHoonYu96 commented Nov 28, 2024

➕ 이슈 번호

  • #hotfix

🔎 작업 내용

redis player속성이 바뀔때만 event가 발생하는것을 몰랐네요;;

  • player의 속성변경 -> event 발생 -> changes로 무슨 event인지 확인 -> 핸들링
    image
    image

선택지 동적결정

image

joinRoom시 host여부 전송

image


🖼 참고 이미지


🎯 리뷰 요구사항 (선택)

  • 특별히 봐줬으면 하는 부분이 있다면 적어주세요

✅ Check List

  • merge할 브랜치의 위치를 확인했나요?
  • Label을 지정했나요?

@DongHoonYu96 DongHoonYu96 requested a review from Copilot November 28, 2024 08:57

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (1)

BE/src/game/service/game.room.service.ts:306

  • Commenting out this line may cause the player exit handling to be skipped. Ensure this is intentional.
// await this.handlePlayerExit(kickPlayerId);
@DongHoonYu96 DongHoonYu96 added the bug Something isn't working label Nov 28, 2024
기존방의플레이어에게 새로운 플레이어 알림 / 새 플레이어에게 기존방의 플레이어들 알림
@DongHoonYu96 DongHoonYu96 changed the title [BE] fix: [BE] 강퇴시 kickRoom event 발송 [BE] fix: [BE] 강퇴시 kickRoom event 발송, 선택지 동적결정, joinRoom시 host여부 전송 Nov 28, 2024
@DongHoonYu96 DongHoonYu96 requested a review from Copilot November 28, 2024 13:55

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (2)

BE/src/game/service/game.room.service.ts:89

  • [nitpick] The variable name 'findHost' is ambiguous. It should be renamed to 'hostId'.
const findHost = findRoom.host;

.github/workflows/deploy.yml:8

  • Changing NODE_ENV to 'test' will break the build. It should be 'production'.
NODE_ENV: test #이걸 바꾸면 BE 빌드가 안됨
@DongHoonYu96 DongHoonYu96 merged commit 5ffc3eb into boostcampwm-2024:dev-be Nov 28, 2024
@DongHoonYu96 DongHoonYu96 deleted the hotfix-be-#3 branch December 2, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants