-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BE] fix: [BE] 강퇴시 kickRoom event 발송, 선택지 동적결정, joinRoom시 host여부 전송 #288
[BE] fix: [BE] 강퇴시 kickRoom event 발송, 선택지 동적결정, joinRoom시 host여부 전송 #288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (1)
BE/src/game/service/game.room.service.ts:306
- Commenting out this line may cause the player exit handling to be skipped. Ensure this is intentional.
// await this.handlePlayerExit(kickPlayerId);
기존방의플레이어에게 새로운 플레이어 알림 / 새 플레이어에게 기존방의 플레이어들 알림
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (2)
BE/src/game/service/game.room.service.ts:89
- [nitpick] The variable name 'findHost' is ambiguous. It should be renamed to 'hostId'.
const findHost = findRoom.host;
.github/workflows/deploy.yml:8
- Changing NODE_ENV to 'test' will break the build. It should be 'production'.
NODE_ENV: test #이걸 바꾸면 BE 빌드가 안됨
➕ 이슈 번호
🔎 작업 내용
redis player속성이 바뀔때만 event가 발생하는것을 몰랐네요;;
선택지 동적결정
joinRoom시 host여부 전송
🖼 참고 이미지
🎯 리뷰 요구사항 (선택)
✅ Check List