Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] feat#281 카테고리 enum 설정 #282

Merged
merged 3 commits into from
Nov 28, 2024
Merged

[BE] feat#281 카테고리 enum 설정 #282

merged 3 commits into from
Nov 28, 2024

Conversation

DongHoonYu96
Copy link
Collaborator

@DongHoonYu96 DongHoonYu96 commented Nov 28, 2024 •
edited
Loading

➕ 이슈 번호


🔎 작업 내용

  • 카테고리 enum 설정
  • 클라에게 구체적인 에러 메세지 전송

🖼 참고 이미지

image
image
image


🎯 리뷰 요구사항 (선택)

  • 특별히 봐줬으면 하는 부분이 있다면 적어주세요

✅ Check List

  • merge할 브랜치의 위치를 확인했나요?
  • Label을 지정했나요?

@DongHoonYu96 DongHoonYu96 requested a review from Copilot November 28, 2024 02:28
Copilot
Copilot AI reviewed Nov 28, 2024
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 suggestion.

BE/src/quiz-set/entities/quiz-set.entity.ts Outdated
SPORTS: 'SPORTS',
GAME: 'GAME',
IT: 'IT',
POLITIC: 'POLITIC'
Copy link
Preview

Copilot AI Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The enum name 'POLITIC' should be corrected to 'POLITICS'.

Suggested change
POLITIC: 'POLITIC'
POLITICS: 'POLITICS'

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@DongHoonYu96 DongHoonYu96 self-assigned this Nov 28, 2024
ijun17
ijun17 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@ijun17 ijun17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

always97
always97 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@always97 always97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다

NewCodes7
NewCodes7 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@NewCodes7 NewCodes7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

songbuild00
songbuild00 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@songbuild00 songbuild00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😀

@DongHoonYu96 DongHoonYu96 merged commit 6b83551 into boostcampwm-2024:dev-be Nov 28, 2024
@DongHoonYu96 DongHoonYu96 deleted the feature-be-#281 branch November 28, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@NewCodes7 NewCodes7 NewCodes7 approved these changes

@always97 always97 always97 approved these changes

@ijun17 ijun17 ijun17 approved these changes

@songbuild00 songbuild00 songbuild00 approved these changes

Assignees

@DongHoonYu96 DongHoonYu96

Labels
6. 퀴즈셋 생성 구현
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DongHoonYu96 @songbuild00 @ijun17 @always97 @NewCodes7