Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] test# 테스트 코드 오류 수정 및 deploy.yml 수정 #278

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

songbuild00
Copy link
Collaborator

@songbuild00 songbuild00 commented Nov 27, 2024

➕ 이슈 번호

  • #이슈번호

🔎 작업 내용

  • 테스트 코드 오류 수정 (extraHeaders -> query)

✅ Check List

  • merge할 브랜치의 위치를 확인했나요?
  • Label을 지정했나요?

@songbuild00 songbuild00 requested review from DongHoonYu96, ijun17, NewCodes7 and always97 and removed request for DongHoonYu96 and ijun17 November 27, 2024 15:52
@songbuild00 songbuild00 self-assigned this Nov 27, 2024
@songbuild00 songbuild00 added the bug Something isn't working label Nov 27, 2024
Copy link
Collaborator

@DongHoonYu96 DongHoonYu96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.
LGTM

@DongHoonYu96 DongHoonYu96 requested a review from Copilot November 27, 2024 16:41

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no suggestions.

Files not reviewed (3)
  • BE/package.json: Language not supported
  • BE/src/game/game.gateway.ts: Evaluated as low risk
  • BE/test/integration/setup/socket.helper.ts: Evaluated as low risk
Copy link
Collaborator

@ijun17 ijun17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

Copy link
Collaborator

@NewCodes7 NewCodes7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!!

Copy link
Collaborator

@always97 always97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.

@songbuild00 songbuild00 merged commit 5b9e261 into boostcampwm-2024:dev-be Nov 28, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants