Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] 메인페이지, 게임생성페이지, PIN페이지 디자인 개선 및 통일 #273

Merged
merged 6 commits into from
Nov 27, 2024

Conversation

always97
Copy link
Collaborator

@always97 always97 commented Nov 26, 2024

🔎 작업 내용

  • 1차 디자인 공사 완료했습니다.
    • 메인페이지는 깔끔하게 하고 게임에 입장하면 (게임페이지) 좀 더 아케이드 느낌 가져가도 좋을것같습니다.
    • 메인페이지, 게임생성페이지, PIN페이지 디자인 개선 및 통일
  • 게임 생성 옵션 중 최대 인원 설정 ux 기능 개선
    • 슬라이더를 이용해서 정확한 인원 설정의 어려움이 있을수 있음 -> 직접 입력 설정도 가능

🖼 참고 이미지

  • 메인페이지 디자인 (반응형)

메인페이지

  • 게임 생성 옵션 최대 인원 기능 ux 개선

  • PIN 페이지


🎯 리뷰 요구사항 (선택)

  • 특별히 봐줬으면 하는 부분이 있다면 적어주세요

✅ Check List

  • merge할 브랜치의 위치를 확인했나요?
  • Label을 지정했나요?

@always97 always97 self-assigned this Nov 26, 2024
Copy link
Collaborator

@DongHoonYu96 DongHoonYu96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

디자인 너무 예쁘네요
고생하셨습니다~!

Copy link
Collaborator

@ijun17 ijun17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

크으으 👍

@DongHoonYu96 DongHoonYu96 requested a review from Copilot November 27, 2024 01:19

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 9 changed files in this pull request and generated no suggestions.

Files not reviewed (3)
  • FE/src/assets/lottie/fail_effect.json: Language not supported
  • FE/src/features/game/pages/GameSetupPage.tsx: Evaluated as low risk
  • FE/src/features/game/pages/PinPage.tsx: Evaluated as low risk
Copy link
Collaborator

@songbuild00 songbuild00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 이쁘네요
게임방 생성 화면도 뭔가 레이아웃이 깔끔해진 것 같습니다!

Copy link
Collaborator

@NewCodes7 NewCodes7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다 ㅎㅎ

@always97 always97 merged commit d7ba9f6 into boostcampwm-2024:dev-fe Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants