[FE] feat 디자인 #272
[FE] feat 디자인 #272
Conversation
Copilot
AI
left a comment
Copilot
AI
left a comment
There was a problem hiding this comment.
Copilot reviewed 5 out of 20 changed files in this pull request and generated 3 suggestions.
Files not reviewed (15)
- FE/src/index.css: Language not supported
- FE/src/features/game/data/socketListener.ts: Evaluated as low risk
- FE/src/features/game/components/ResultModal.tsx: Evaluated as low risk
- FE/src/features/game/components/QuizHeader.tsx: Evaluated as low risk
- FE/src/features/game/components/AnswerModal.tsx: Evaluated as low risk
- FE/src/features/game/components/ParticipantDisplay.tsx: Evaluated as low risk
- FE/src/features/game/pages/GameSetupPage.tsx: Evaluated as low risk
- FE/src/features/game/components/NicknameModal.tsx: Evaluated as low risk
- FE/src/features/game/pages/GamePage.tsx: Evaluated as low risk
- FE/src/features/game/components/QuizSettingModal.tsx: Evaluated as low risk
- FE/src/api/socket/socketEventTypes.ts: Evaluated as low risk
- FE/tailwind.config.js: Evaluated as low risk
- FE/src/features/game/pages/PinPage.tsx: Evaluated as low risk
- FE/src/features/game/components/GameHeader.tsx: Evaluated as low risk
- FE/src/features/game/data/store/usePlayerStore.ts: Evaluated as low risk
| @@ -6,8 +6,27 @@ type SocketEvent = keyof SocketDataMap; | |||
| export class SocketMock { | |||
| private listenerSet: Record<string, ((...args: unknown[]) => void)[]> = {}; | |||
| private onAnyListenerList: ((event: string, ...args: unknown[]) => void)[] = []; | |||
| initialrized: Promise<void>; | |||
There was a problem hiding this comment.
The variable name 'initialrized' is misspelled. It should be 'initialized'.
| initialrized: Promise<void>; | |
| initialized: Promise<void>; |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
| @@ -65,8 +65,22 @@ const QuizSetSearchList = ({ onClick, search }: Params) => { | |||
| return () => observer.disconnect(); | |||
| }, [onIntersect]); | |||
|
|
|||
| if (isLoading) return <p>Loading...</p>; | |||
| if (isError) return <p>Error fetching data.</p>; | |||
| if (isLoading) return; | |||
There was a problem hiding this comment.
The loading message is not displayed correctly. It should be if (isLoading) return <p>Loading...</p>;.
| if (isLoading) return; | |
| if (isLoading) return <p>Loading...</p>; |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
| <div | ||
| className="mt-2 text-[0.625rem]" | ||
| style={{ | ||
| color: isCurrent ? 'lightgreen' : 'inherit', | ||
| opacity: isCurrent ? '1' : '0.2', |
There was a problem hiding this comment.
[nitpick] Reducing the opacity of non-current players' names to 0.2 might impact readability. Consider using a different method to highlight the current player without reducing the readability of other players' names.
| opacity: isCurrent ? '1' : '0.2', | |
| fontWeight: isCurrent ? 'bold' : 'normal', |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
| socketService.on('selfId', (data) => { | ||
| const playerName = usePlayerStore.getState().players.get(data.playerId); | ||
| usePlayerStore.getState().setCurrentPlayerId(data.playerId); | ||
| usePlayerStore.getState().setCurrentPlayerName(String(playerName)); | ||
| }); |
There was a problem hiding this comment.
저는 API 명세서 보고 이벤트 이름을 getSelfID 로 해두었는데, 여기는 selfId 로 되어 있네요..!
There was a problem hiding this comment.
| socketService.on('selfId', (data) => { | |
| const playerName = usePlayerStore.getState().players.get(data.playerId); | |
| usePlayerStore.getState().setCurrentPlayerId(data.playerId); | |
| usePlayerStore.getState().setCurrentPlayerName(String(playerName)); | |
| }); | |
| socketService.on('getSelfId', (data) => { | |
| const playerName = usePlayerStore.getState().players.get(data.playerId); | |
| usePlayerStore.getState().setCurrentPlayerId(data.playerId); | |
| usePlayerStore.getState().setCurrentPlayerName(String(playerName)); | |
| }); |
ex) [BE] feat#156 자동배포 구현
(확인 후 지워주세요)
➕ 이슈 번호
🔎 작업 내용
한번 봐주세용
https://news.taskify.shop/game/test-load-with-quiz
🖼 참고 이미지
🎯 리뷰 요구사항 (선택)
✅ Check List