[BE] feat#229 모니터링 구현 v4 #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpu, mem, connection 상황 출력
| return { | ||
| connectedClients: connected_clients, | ||
| usedMemoryMB: Math.round(used_memory / 1024 / 1024), | ||
| clientList: String(clientList).split('\n').length, |
There was a problem hiding this comment.
Using String(clientList).split('\n').length to count clients may not be accurate. Consider using a more reliable method to count the clients.
Suggested change
| clientList: String(clientList).split('\n').length, | |
| clientList: clientList.trim().split('\n').filter(line => line).length, |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
| '\nRedis Connections:\n' + | ||
| `Connected Clients: ${metrics.redis.connectedClients}, ` + | ||
| `Used Memory: ${metrics.redis.usedMemoryMB}MB\n` + | ||
| `클라이언트 큐 길이: ${metrics.redis.queueLength}\n` + |
There was a problem hiding this comment.
The log message should be in English for consistency. Change '클라이언트 큐 길이' to 'Client Queue Length'.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
https://admin.socket.io/#/ 여기접속후 서버주소 입력하면 모니터링 가능
songbuild00
approved these changes
Nov 27, 2024
NewCodes7
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➕ 이슈 번호
🔎 작업 내용
개발일지 : https://www.notion.so/s0n9/e06f9bceb4cb40838bfa58127f1586e9?pvs=4
핵심주제 : 비동기에서 누가 누구를 호출했는지 어떻게 알아낼지
https://tv.naver.com/v/11210781
이 풀 리퀘스트에는 다음과 같은 주요 변경 사항이 포함됩니다:
의존성 업데이트:
@socket.io/admin-ui 패키지를 package.json 및 package-lock.json 파일에 추가했습니다.
로깅 및 모니터링 개선:
SystemMetricsService를 도입하여 CPU 사용량, 메모리 사용량, MySQL 및 Redis 지표와 같은 시스템 지표를 수집합니다.
SocketEventLoggerInterceptor를 업데이트하여 CPU 및 메모리 사용량, MySQL 및 Redis 지표와 같은 시스템 지표를 소켓 이벤트에 대해 기록합니다.
모듈 및 인터셉터 변경사항:
CommonModule을 생성하여 SocketEventLoggerInterceptor와 SystemMetricsService를 제공하고 내보냅니다.
SocketEventLoggerInterceptor를 수정하여 SystemMetricsService를 사용하여 시스템 지표를 기록하도록 했습니다.
Socket.IO 관리 UI 통합:
game.gateway.ts에서 Socket.IO 관리 UI를 통합하여 소켓 연결 및 이벤트를 모니터링할 수 있게 했습니다.
게임 모듈 업데이트:
GameModule의 공급자에 SocketEventLoggerInterceptor와 SystemMetricsService를 추가했습니다.
🖼 참고 이미지
🎯 리뷰 요구사항 (선택)
✅ Check List