Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] feat#263 강퇴구현, 모니터링 도입 #267

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

DongHoonYu96
Copy link
Collaborator

@DongHoonYu96 DongHoonYu96 commented Nov 25, 2024

➕ 이슈 번호


🔎 작업 내용


🖼 참고 이미지

image
image


🎯 리뷰 요구사항 (선택)

  • 소켓도 지원되게 도전?
  • 원래는 모니터링용 서버를 하나 더 띄우는게 정석, 일단 was 서버에 넣어놓음.

✅ Check List

  • merge할 브랜치의 위치를 확인했나요?
  • Label을 지정했나요?

todo : 재입장 불가
최상단 import 해야함에 주의
@DongHoonYu96 DongHoonYu96 requested a review from Copilot November 25, 2024 16:18
@DongHoonYu96 DongHoonYu96 self-assigned this Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 11 changed files in this pull request and generated no suggestions.

Files not reviewed (6)
  • BE/package-lock.json: Language not supported
  • BE/package.json: Language not supported
  • BE/.eslintrc.js: Evaluated as low risk
  • BE/src/common/constants/exception-message.ts: Evaluated as low risk
  • BE/src/common/constants/socket-events.ts: Evaluated as low risk
  • BE/src/game/dto/kick-room.dto.ts: Evaluated as low risk
@DongHoonYu96 DongHoonYu96 changed the title Feature be #263 [BE] feat#263 강퇴구현, 모니터링 도입 Nov 25, 2024
이래야 mysql, 함수 콜스택 지원
Copy link
Collaborator

@ijun17 ijun17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 핀 포인트 신기

Copy link
Collaborator

@always97 always97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다. 핀포인트 신기하네요

Copy link
Collaborator

@songbuild00 songbuild00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

Comment on lines +8 to +9
// env 불러오기
config({ path: join(__dirname, '..', '.env') }); // ../ 경로의 .env 로드
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요거는 env 로딩 안 되는 문제때문에 시도하신걸까요?

@DongHoonYu96 DongHoonYu96 merged commit 9e7175f into boostcampwm-2024:dev-be Nov 26, 2024
@DongHoonYu96 DongHoonYu96 deleted the feature-be-#263 branch November 26, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants