[FE] feat#30 강퇴 기능 구현 및 채팅렌더링 최적화 #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
always97
requested review from
songbuild00,
DongHoonYu96,
ijun17 and
NewCodes7
always97
changed the title
DongHoonYu96
approved these changes
Nov 25, 2024
| @@ -127,6 +127,11 @@ socketService.on('endGame', () => { | |||
| useRoomStore.getState().setGameState(GameState.END); | |||
| }); | |||
|
|
|||
| socketService.on('kickRoom', () => { | |||
| alert('강퇴당하였습니다.'); | |||
| // 메인페이지 or 로비로 이동시키기? | |||
There was a problem hiding this comment.
논의결과 : 모달 후 메인페이지로 이동 버튼
ijun17
approved these changes
Nov 26, 2024
| import { QuizSettingModal } from './QuizSettingModal'; | ||
| import { socketService } from '@/api/socket'; | ||
| import { usePlayerStore } from '@/features/game/data/store/usePlayerStore'; | ||
| import { useQuizStore } from '@/features/game/data/store/useQuizStore'; | ||
|
|
||
| export const GameHeader = () => { | ||
| export const GameHeader = React.memo(() => { |
NewCodes7
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➕ 이슈 번호
🔎 작업 내용
🖼 참고 이미지
개선 전
개선 후
🎯 리뷰 요구사항 (선택)
✅ Check List