Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] hotfix#1 #247

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

DongHoonYu96
Copy link
Collaborator

@DongHoonYu96 DongHoonYu96 commented Nov 21, 2024

새롭게 입장한 플레이어는 어떤 게임모드인지 모르고, 디폴트가 SURVIVAL로 잡히는 버그수정

➕ 이슈 번호

  • #이슈번호

🔎 작업 내용

  • 작업 내용을 설명해주세요

🖼 참고 이미지


🎯 리뷰 요구사항 (선택)

  • 특별히 봐줬으면 하는 부분이 있다면 적어주세요

✅ Check List

  • merge할 브랜치의 위치를 확인했나요?
  • Label을 지정했나요?

새롭게 입장한 플레이어는 어떤 게임모드인지 모르고, 디폴트가 SURVIVAL로 잡힘
@DongHoonYu96 DongHoonYu96 requested a review from Copilot November 21, 2024 08:49
@DongHoonYu96 DongHoonYu96 self-assigned this Nov 21, 2024
@DongHoonYu96 DongHoonYu96 added the bug Something isn't working label Nov 21, 2024
@songbuild00 songbuild00 changed the title [BE] hotfit#1 [BE] hotfix#1 Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 11 changed files in this pull request and generated no suggestions.

Files not reviewed (6)
  • BE/src/auth/auth.controller.spec.ts: Evaluated as low risk
  • BE/src/auth/auth.service.spec.ts: Evaluated as low risk
  • BE/src/user/user.service.spec.ts: Evaluated as low risk
  • BE/src/game/dto/create-game.dto.ts: Evaluated as low risk
  • BE/src/game/redis/subscribers/room.subscriber.ts: Evaluated as low risk
  • BE/test/integration/game.integration.spec.ts: Evaluated as low risk
Copy link
Collaborator

@always97 always97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥💥!

@NewCodes7 NewCodes7 merged commit 00bf451 into boostcampwm-2024:dev-be Nov 21, 2024
1 check failed
@DongHoonYu96 DongHoonYu96 deleted the hotfix-be-#1 branch November 25, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants