Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] feat#241 자동배포 수정 #243

Merged
merged 7 commits into from
Nov 21, 2024

Conversation

DongHoonYu96
Copy link
Collaborator

@DongHoonYu96 DongHoonYu96 commented Nov 21, 2024

➕ 이슈 번호


🔎 작업 내용

  • 자동배포 수정
    dist/src내의 main.js를 실행하도록 변경

image

안되던게 그냥 env파일 ip를 잘못적어줘서인가? 그런듯

현재 config경로
image

여기있는 env를 잘찾는다.
image


🖼 참고 이미지


🎯 리뷰 요구사항 (선택)

  • 특별히 봐줬으면 하는 부분이 있다면 적어주세요

✅ Check List

  • merge할 브랜치의 위치를 확인했나요?
  • Label을 지정했나요?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (1)

BE/src/game/interceptor/gameActivity.interceptor.ts:23

  • [nitpick] The log message is in Korean. Ensure consistency in log message language across the codebase.
this.logger.debug(`방 ${data.gameId} 활동시간 갱신 완료 / after ${Date.now() - before}ms`);
Copy link
Collaborator

@NewCodes7 NewCodes7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다! 이 PR은 테스트 커밋도 있어서 스쿼시 머지하면 될 것 같네여!

Copy link
Collaborator

@always97 always97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

@DongHoonYu96 DongHoonYu96 merged commit b544916 into boostcampwm-2024:dev-be Nov 21, 2024
NewCodes7 added a commit that referenced this pull request Nov 21, 2024
@DongHoonYu96 DongHoonYu96 deleted the feature-be-#241 branch November 21, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants