[FE] feat#233#210 API 분리 및 함수 구현 & 서비스 전체 예외상황 리스트 체크 #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DongHoonYu96
approved these changes
Nov 20, 2024
NewCodes7
approved these changes
Nov 21, 2024
| @@ -14,6 +14,7 @@ | |||
| "@emotion/styled": "^11.13.0", | |||
| "@mui/material": "^6.1.6", | |||
| "@tanstack/react-query": "^5.59.19", | |||
| "axios": "^1.7.7", | |||
There was a problem hiding this comment.
fetch가 아닌 axios를 선택한 이유가 있을까요? (궁금)
Comment on lines
+77
to
+89
| onPermanently<T extends SocketEvent>( | ||
| event: T, | ||
| callback: (data: SocketDataMap[T]['response']) => void | ||
| ) { | ||
| const handler = () => this.socket.on(event, callback); | ||
| this.handlers.push(handler); | ||
| if (this.isActive()) handler(); | ||
| } | ||
|
|
||
| emit<T extends SocketEvent>(event: T, data: SocketDataMap[T]['request']) { | ||
| this.socket.emit(event, data); | ||
| on<T extends SocketEvent>(event: T, callback: (data: SocketDataMap[T]['response']) => void) { | ||
| if (this.isActive()) this.socket.on(event, callback); | ||
| } | ||
|
|
There was a problem hiding this comment.
onPermanently와 on의 쓰임새는 어떻게 다른가요? (궁금)
There was a problem hiding this comment.
on함수 -> socket이 바뀌면 리스너가 사라짐 -> 등록했다가 지워야 될때 사용 (ui작업)
onPermanently -> socket이 바뀌어도 안사라짐
songbuild00
approved these changes
Nov 21, 2024
crongro
reviewed
Nov 21, 2024
Comment on lines
+44
to
+48
| if (axios.isAxiosError(error)) { | ||
| console.error('Signup Error:', error.response?.data || error.message); | ||
| } else { | ||
| console.error('Unexpected Error:', error); | ||
| } |
There was a problem hiding this comment.
이부분이 login과 비슷하게 할거면 통합해서 함수로 만들어도 될 듯.
| import axiosInstance from './instance'; | ||
|
|
||
| type LoginResponse = { | ||
| result: string; |
There was a problem hiding this comment.
result는 좀더 구체적인 이름으로. string말고 더 구체적인 형태도 될 듯? 보통 응답은 객체로 하면 객체타입으로 표현해도 되고요.
| if (axios.isAxiosError(error)) { | ||
| console.error('Login Error:', error.response?.data || error.message); | ||
| } else { | ||
| console.error('Unexpected Error:', error); |
There was a problem hiding this comment.
에러처리의 목적인 개발자에게 보여줄것인가? 사용자에게 다음행동을 유도할것인가? 를 생각해서 처리하면더 좋을듯요.
| return response.data; | ||
| } catch (error) { | ||
| console.error('Error fetching room list:', error); | ||
| return null; |
| @@ -0,0 +1,58 @@ | |||
| export type QuizSet = { | |||
| id: string; | |||
| export type QuizSetDetailResponse = { | ||
| id: string; | ||
| title: string; | ||
| category: string; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➕ 이슈 번호
🔎 작업 내용
🖼 참고 이미지
🎯 리뷰 요구사항 (선택)
✅ Check List